Bugzilla – Attachment 80361 Details for
Bug 21539
addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21539 - addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder
Bug-21539---addorderiso2709pl-forces-librarian-to-.patch (text/plain), 2.46 KB, created by
Kyle M Hall (khall)
on 2018-10-10 15:18:01 UTC
(
hide
)
Description:
Bug 21539 - addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2018-10-10 15:18:01 UTC
Size:
2.46 KB
patch
obsolete
>From 7b3e5e8c0b7d669b0a795cf60e7408dfb38db06b Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 10 Oct 2018 11:13:37 -0400 >Subject: [PATCH] Bug 21539 - addorderiso2709.pl forces librarian to select a > ccode and notforloan code when using MarcItemFieldsToOrder > >There is no reason that MarcItemFieldsToOrder should force librarians to select a ccode and notforloan value for each item. They are both optional fields. As with location, the first value should be an empty 'none' option. > >Test Plan: >1) Set up MarcItemFieldsToOrder, do *not* set mappings for ccode and notforloan >2) Add an order record to a basket that uses MarcItemFieldsToOrder >3) Note you must choose a ccode and nfl value >4) Apply this patch >5) Reload the page >6) Note you no longer have to select values for ccode and notforloan >--- > .../intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >index 3431a06e5d..28fb283d7b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >@@ -206,6 +206,7 @@ > </li> > > <li><label for="ccode_item_[% item.item_id | html %]">ccode</label><select id="ccode_item_[% item.item_id | html %]" name="ccode_[% item.biblio_count | html %]"> >+ <option value=""> </option> > [% FOREACH ccodeloo IN ccodeloop %] > [% IF ( ccodeloo.code ) == (item.ccode) %]<option value="[% ccodeloo.code | html %]" selected="selected">[% ccodeloo.description | html %]</option>[% ELSE %]<option value="[% ccodeloo.code | html %]">[% ccodeloo.description | html %]</option>[% END %] > [% END %] >@@ -213,6 +214,7 @@ > </li> > > <li><label for="notforloan_item_[% item.item_id | html %]">notforloan</label><select id="notforloan_item_[% item.item_id | html %]" name="notforloan_[% item.biblio_count | html %]"> >+ <option value=""> </option> > [% FOREACH n IN notforloanloop %] > [% IF n.code == item.notforloan %] > <option value="[% n.code | html %]" selected="selected">[% n.description | html %]</option> >-- >2.17.1 (Apple Git-112)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21539
:
80361
|
108553
|
108935