Bugzilla – Attachment 80392 Details for
Bug 21505
Box around 'Additional fields' does not contain the fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21505: Box around 'Additional fields' does not contain the fields
Bug-21505-Box-around-Additional-fields-does-not-co.patch (text/plain), 2.03 KB, created by
Claire Gravely
on 2018-10-11 10:09:00 UTC
(
hide
)
Description:
Bug 21505: Box around 'Additional fields' does not contain the fields
Filename:
MIME Type:
Creator:
Claire Gravely
Created:
2018-10-11 10:09:00 UTC
Size:
2.03 KB
patch
obsolete
>From ca7cacdcf79a8fdddf57aeb64b8462d6843c29fb Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 9 Oct 2018 18:05:04 +0000 >Subject: [PATCH] Bug 21505: Box around 'Additional fields' does not contain > the fields > >This patch modifies the subscription detail page markup to eliminate a >confusing bordered <legend> tag. It is replaced with an <hr> to >delineate the sections and an <h3> tag to serve as the heading. > >To test, apply the patch and regenerate the staff client CSS. > > - Configure one or more additional subscription fields. > - View the detail page for a subscription and confirm that the > "Additional fields" section is clearly labeled. > >Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> >--- > koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 1 + > .../intranet-tmpl/prog/en/modules/serials/subscription-detail.tt | 5 +++-- > 2 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index 8fc9058..f2780db 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -413,6 +413,7 @@ h6 { > > hr { > clear: both; >+ margin: 1em 0; > } > > p { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >index 55d4e68..dc1e32e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >@@ -115,11 +115,12 @@ > </div> > </div> > >- [% IF additional_fields_for_subscription %] >+ [% IF additional_fields_for_subscription %] >+ <hr> > <div class="row"> > <div class="col-sm-6"> >+ <h3>Additional fields:</h3> > <div class="rows"> >- <legend>Additional fields:</legend> > <ol> > [% FOR field IN additional_fields_for_subscription %] > <li> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21505
:
80147
|
80303
|
80392
|
80423