Attachment 80399 Details for Bug 21531 – Bug 21531: Subscription "New fields" button should read "New field"

[patch] Bug 21531: Subscription "New fields" button should read "New field"

Bug-21531-Subscription-New-fields-button-should-re.patch (text/plain), 2.78 KB, created by Claire Gravely on 2018-10-11 10:35:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Claire Gravely

Created: 2018-10-11 10:35:17 UTC

Size: 2.78 KB

patch

obsolete

>From b165f6b1157a199b15ce565100538d58f02667d4 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 10 Oct 2018 12:10:45 +0000
>Subject: [PATCH] Bug 21531: Subscription "New fields" button should read "New
> field"
>
>This patch changes the label of the "New fields" button on the
>subscription add fields page to read "New field," making it consistent
>with similar buttons in the staff client.
>
>Also changed:
>
>- Add missing id to <select> to make label clickable.
>- Remove custom DataTables configuration in favor of defaults.
>
>To test, apply the patch and go to Serials -> Add subscription fields.
>
>- The button in the toolbar should read "New field."
>- The DataTables' functionality of the table of existing custom fields
>  should be correct.
>- Click the "New field" button.
>  - Cliking the "Authorised value category" label should put the focus
>    on the dropdown.
>
>Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt
>index 0c88a8d..3acef19 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt
>@@ -30,7 +30,7 @@
> 
>   [% IF op == 'list' %]
>     <div id="toolbar" class="btn-toolbar">
>-      <a class="btn btn-default btn-sm" id="newfields" href="/cgi-bin/koha/serials/add_fields.pl?op=add_form"><i class="fa fa-plus"></i> New fields</a>
>+      <a class="btn btn-default btn-sm" id="newfields" href="/cgi-bin/koha/serials/add_fields.pl?op=add_form"><i class="fa fa-plus"></i> New field</a>
>     </div>
>   [% END %]
> 
>@@ -107,7 +107,7 @@
>           </li>
>           <li>
>             <label for="av">Authorised value category: </label>
>-            <select name="authorised_value_category">
>+            <select id="av" name="authorised_value_category">
>               <option value="">None</option>
>               [% PROCESS options_for_authorised_value_categories authorised_value_categories => AuthorisedValues.GetCategories( selected => field.authorised_value_category ) %]
>             </select>
>@@ -154,11 +154,7 @@
> 
>             $("#fieldst").dataTable($.extend(true, {}, dataTablesDefaults, {
>                 'bAutoWidth': false,
>-                'sDom': 't<"bottom pager"ilpf>',
>                 'sPaginationType': 'four_button',
>-                'aLengthMenu': [[10, 20, 50, 100, -1], [10, 20, 50, 100, "All"]],
>-                'iDisplayLength': 20,
>-                'aaSorting': [[ 0, "asc" ]],
>                 "aoColumnDefs": [
>                     { "aTargets": [ -1 ], "bSortable": false, "bSearchable": false },
>                 ]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 21531: 80336 | 80399 | 80421