Bugzilla – Attachment 80453 Details for
Bug 17509
Notify patrons to return items requested on hold by another person
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17509: Added system preference to restrict recipients based on library
Bug-17509-Added-system-preference-to-restrict-reci.patch (text/plain), 4.00 KB, created by
Josef Moravec
on 2018-10-12 08:26:49 UTC
(
hide
)
Description:
Bug 17509: Added system preference to restrict recipients based on library
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2018-10-12 08:26:49 UTC
Size:
4.00 KB
patch
obsolete
>From 8e19dd6e32f99dc2207683c54a952b57921ab9d6 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Radek=20=C5=A0iman?= <rbit@rbit.cz> >Date: Thu, 3 Nov 2016 01:07:00 +0100 >Subject: [PATCH] Bug 17509: Added system preference to restrict recipients > based on library > >Test plan: >1) apply patch >2) go to System preferences / Circulation / Holds Policy >3) change which patrons will be contacted >4) compare your change against database value >NotifyToReturnItemFromLibrary > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > .../bug_17509_add_NotifyToReturnItemWhenHoldIsPlaced_syspref.sql | 3 ++- > installer/data/mysql/sysprefs.sql | 1 + > .../prog/en/modules/admin/preferences/circulation.pref | 7 ++++++- > 3 files changed, 9 insertions(+), 2 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_17509_add_NotifyToReturnItemWhenHoldIsPlaced_syspref.sql b/installer/data/mysql/atomicupdate/bug_17509_add_NotifyToReturnItemWhenHoldIsPlaced_syspref.sql >index 4c341c1..f4ff752 100644 >--- a/installer/data/mysql/atomicupdate/bug_17509_add_NotifyToReturnItemWhenHoldIsPlaced_syspref.sql >+++ b/installer/data/mysql/atomicupdate/bug_17509_add_NotifyToReturnItemWhenHoldIsPlaced_syspref.sql >@@ -1 +1,2 @@ >-INSERT IGNORE INTO systempreferences (variable,value,explanation,options,type) VALUES ('NotifyToReturnItemWhenHoldIsPlaced', '0', 'If ON, notifies the borrowers to return an item whenever a hold is placed on it', NULL, 'YesNo'); >+INSERT IGNORE INTO systempreferences (variable,value,explanation,options,type) VALUES ('NotifyToReturnItemWhenHoldIsPlaced', '0', 'If ON, notifies the patrons to return an item whenever a hold is placed on it', NULL, 'YesNo'); >+INSERT IGNORE INTO systempreferences (variable,value,explanation,options,type) VALUES ('NotifyToReturnItemFromLibrary', 'PatronLibrary', 'Restricts which libraries to take into consideration when notifying patrons to return items on hold', 'PatronLibrary|AnyLibrary', 'Choice'); >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index a96769e..4e0b42b 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -298,6 +298,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('NoticeBcc','','','Email address to bcc outgoing notices sent by email','free'), > ('NoticeCSS','',NULL,'Notices CSS url.','free'), > ('NotifyBorrowerDeparture','30',NULL,'Define number of days before expiry where circulation is warned about patron account expiry','Integer'), >+('NotifyToReturnItemFromLibrary','PatronLibrary','PatronLibrary|AnyLibrary','Restricts which libraries to take into consideration when notifying patrons to return items on hold','Choice'), > ('NotifyToReturnItemWhenHoldIsPlaced','0',NULL,'If ON, notifies the borrowers to return an item whenever a hold is placed on it','YesNo'), > ('NovelistSelectEnabled','0',NULL,'Enable Novelist Select content. Requires Novelist Profile and Password','YesNo'), > ('NovelistSelectPassword','',NULL,'Novelist select user Password','free'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index 9ec4772..0cdaedc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -654,7 +654,12 @@ Circulation: > choices: > yes: Enable > no: "Don't enable" >- - "sending an email to the borrowers to return an item whenever a hold request is placed on it." >+ - sending an email to the patrons to return an item whenever a hold request is placed on it. If enabled, contact patrons from >+ - pref: NotifyToReturnItemFromLibrary >+ choices: >+ PatronLibrary: "patron's home library" >+ AnyLibrary: "any library" >+ - . > - > - pref: DisplayMultiPlaceHold > choices: >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17509
:
57143
|
57144
|
57145
|
57146
|
57147
|
57148
|
57149
|
57150
|
57157
|
57159
|
57160
|
57161
|
57162
|
57163
|
57164
|
57165
|
63258
|
63269
|
63270
|
63271
|
63272
|
63273
|
63274
|
63275
|
63276
|
63277
|
67982
|
80452
|
80453
|
80454
|
80455
|
80456
|
80457
|
80458
|
80459
|
80460
|
80461
|
86365
|
86366
|
86367
|
86368
|
86369