Attachment 80477 Details for Bug 21537 – Bug 21537: Fix typo for options_for_item_types

[patch] Bug 21537: Fix typo for options_for_item_types

Bug-21537-Fix-typo-for-optionsforitemtypes.patch (text/plain), 2.00 KB, created by Jonathan Druart on 2018-10-12 13:42:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-10-12 13:42:01 UTC

Size: 2.00 KB

patch

obsolete

>From ca1101ee0c0ac382ce0b0efbdc11ac5ecf36a8e7 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 10 Oct 2018 15:02:14 +0000
>Subject: [PATCH] Bug 21537: Fix typo for options_for_item_types
>
>To test:
> 0 - Set UseACQFrameworkForBiblioRecords to 'Use'
> 1 - Define a subfield in the ACQ framework linked to authorised value
> 'itemtypes'
> 2 - Make sure that field is visible
> 3 - Create a purchase suggestion
> 4 - Accept it
> 5 - Go to Acquisitions
> 6 - Find a vendor with an open basket, or create one
> 7 - Add to the basket using a suggestion
> 8 - Choose the suggestion
> 9 - Internal server error
>10 - Apply patch
>11 - Place order form a suggestion again
>12 - Confirm that the field linked to itemtypes shows correctly
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>index cd6837acb8..ee4b764741 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>@@ -3,6 +3,7 @@
> [% USE Koha %]
> [% USE KohaDates %]
> [% USE Price %]
>+[% USE ItemTypes %]
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Acquisitions &rsaquo; Basket [% basketno | html %] &rsaquo; [% IF ( ordernumber ) %]Modify order details (line #[% ordernumber | html %])[% ELSE %]New order[% END %]</title>
>@@ -730,7 +731,7 @@
>             <select name="bib_field_value">
>             [% END %]
>                 <option value=""></option>
>-                [% PROCESS options_for_itemtypes itemtypes => ItemTypes.Get(), selected_itemtype => "FIXME" %]
>+                [% PROCESS options_for_item_types itemtypes => ItemTypes.Get(), selected_itemtype => "FIXME" %]
>             </select>
>         [% CASE 'cn_source' %]
>         [% CASE %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21537: 80359 | 80477 | 80504