Attachment 80562 Details for Bug 21503 – Bug 21503: Fix AV to fail to other values

[patch] Bug 21503: Fix AV to fail to other values

Bug-21503-Fix-AV-to-fail-to-other-values.patch (text/plain), 1.64 KB, created by Christopher Brannon on 2018-10-12 19:28:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christopher Brannon

Created: 2018-10-12 19:28:39 UTC

Size: 1.64 KB

patch

obsolete

>From 7a9678c29bc39fecdae23db448e887f33116b60d Mon Sep 17 00:00:00 2001
>From: Christopher Brannon <cbrannon@cdalibrary.org>
>Date: Fri, 12 Oct 2018 18:45:29 +0000
>Subject: [PATCH] Bug 21503: Fix AV to fail to other values
>
>To Test (Test both detail.pl and opac-detail.pl for functionality):
>    1) Apply patch (restart_all)
>    2) Look up an item that has a shelving location with a description
>        defined (opac description too).
>    3) Remove opac description from shelving location.  Refresh
>        opac-detail.pl and note that description fails back to the
>        regular description.  Refresh detail.pl and note no change.
>    4) Remove regular description from shelving location.  Refresh
>        opac-detail.pl and detail.pl.  Note that both default to the
>        shelving location code.
>    5) Remove the shelving location from the LOC table all together.
>        Refresh opac-detail.pl and detail.pl.  Note that both default to
>        the requested selving location code.
>---
> Koha/Template/Plugin/AuthorisedValues.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Template/Plugin/AuthorisedValues.pm b/Koha/Template/Plugin/AuthorisedValues.pm
>index 2692c15a06..e704d5f2dd 100644
>--- a/Koha/Template/Plugin/AuthorisedValues.pm
>+++ b/Koha/Template/Plugin/AuthorisedValues.pm
>@@ -86,8 +86,9 @@ sub GetDescriptionByKohaField {
>             ? $params->{opac}
>                 ? $av->{opac_description}
>                 : $av->{lib}
>-            : ''; # Maybe we should return $params->{authorised_value}?
>-
>+            : $params->{authorised_value}
>+                ? $params->{authorised_value}
>+                : ''
> }
> 
> 1;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21503: 80151 | 80152 | 80233 | 80439 | 80521 | 80544 | 80545 | 80558 | 80561 | 80562 | 80563 | 80601 | 80758 | 80759 | 80762 | 101323 | 101324 | 101325 | 101326 | 101327 | 101328 | 101524 | 101525 | 101526 | 101527 | 101528 | 101529 | 101533 | 101534 | 101535