Attachment 80646 Details for Bug 20078 – Bug 20078: Add accelerated reading indexes to getIndexes

[patch] Bug 20078: Add accelerated reading indexes to getIndexes

Bug-20078-Add-accelerated-reading-indexes-to-getIn.patch (text/plain), 2.52 KB, created by Barton Chittenden on 2018-10-15 21:42:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Barton Chittenden

Created: 2018-10-15 21:42:23 UTC

Size: 2.52 KB

patch

obsolete

>From 84fe096836024480c0cfa37f6f61c42ce70e3679 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 12 Feb 2018 10:58:35 +0000
>Subject: [PATCH] Bug 20078: Add accelerated reading indexes to getIndexes
>
>To test:
>1 - Find a bib with 526$c and 526$d populated, or populate them
> e.g. 526$a 5.5 | 526$d 14
>2 - Try searching for 'arl:5.5' or 'arp:14'
>3 - Your record should be returned in results
>4 - Add the indexes as dropdowns by entering the following in intranetuserjs:
>$(document).ready(function(){
>        // Add Accelerated Reading Level to advanced search
>    if (window.location.href.indexOf("catalogue/search.pl") > -1) {
>        $(".advsearch").append('<option value="arl">Accelerated Reading Level</option>');
>    }
>
>    // Add Accelerated Reading Point to advanced search
>    if (window.location.href.indexOf("catalogue/search.pl") > -1) {
>        $(".advsearch").append('<option value="arp">Accelerated Reading Point</option>');
>    }
>});
>5 - Search using these in the dropdown, your record will not be found
>6 - Apply patch
>7 - Repeat searches directly and by using dropdown, your record should be returned.
>8 - prove t/db_dependent/Search.t
>
>Signed-off-by: Margie Sheppard - Central Kansas Library System CKLS <msheppard@ckls.org>
>---
> C4/Search.pm            | 2 ++
> t/db_dependent/Search.t | 6 ++++--
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Search.pm b/C4/Search.pm
>index 46fafcd..091523c 100644
>--- a/C4/Search.pm
>+++ b/C4/Search.pm
>@@ -1089,6 +1089,8 @@ sub getIndexes{
>                     'an',
>                     'Any',
>                     'at',
>+                    'arl',
>+                    'arp',
>                     'au',
>                     'aub',
>                     'aud',
>diff --git a/t/db_dependent/Search.t b/t/db_dependent/Search.t
>index 67a4348..4ae7ec0 100644
>--- a/t/db_dependent/Search.t
>+++ b/t/db_dependent/Search.t
>@@ -224,6 +224,8 @@ sub run_marc21_search_tests {
> 
>     my $indexes = C4::Search::getIndexes();
>     is(scalar(grep(/^ti$/, @$indexes)), 1, "Title index supported");
>+    is(scalar(grep(/^arl$/, @$indexes)), 1, "Accelerated reading level index supported");
>+    is(scalar(grep(/^arp$/, @$indexes)), 1, "Accelerated reading point index supported");
> 
>     my $bibliomodule = new Test::MockModule('C4::Biblio');
> 
>@@ -929,8 +931,8 @@ sub run_unimarc_search_tests {
> }
> 
> subtest 'MARC21 + DOM' => sub {
>-    plan tests => 108;
>-    run_marc21_search_tests();
>+    plan tests => 110;
>+    run_marc21_search_tests('dom');
> };
> 
> subtest 'UNIMARC + DOM' => sub {
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20078: 71439 | 79431 | 79434 | 80646 | 80647 | 81308 | 81309 | 81310