Bugzilla – Attachment 80658 Details for
Bug 21581
Matching rules for authorities do not respect 'Search index' setting
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21581: Pass through authorities indexes
Bug-21581-Pass-through-authorities-indexes.patch (text/plain), 1.73 KB, created by
Nick Clemens (kidclamp)
on 2018-10-16 15:18:44 UTC
(
hide
)
Description:
Bug 21581: Pass through authorities indexes
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2018-10-16 15:18:44 UTC
Size:
1.73 KB
patch
obsolete
>From 59fc91d7c6b50a7a554f163e7b6ab677bab123c3 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 16 Oct 2018 15:09:32 +0000 >Subject: [PATCH] Bug 21581: Pass through authorities indexes > >FIXME: We need unit tests > >To test: > 1 - Define a rule: > Matching rule code: LCAUTH > Match threshold: 100 > Record type: Authority record > MATCH POINTS > Search index: LC-card-number > Score: 100 > Tag: 010 > Subfield: a > 2 - Have a record with an LC number in 010 > 3 - Export it > 4 - Edit the record in Koha, move the value from 010 to another field > 5 - Import the original record > 6 - Use the matching rule above, you expect it won't match (nothing in 010 anymore) > 7 - It matches?!?!?! > 8 - Enable zebra logging in koha-conf.xml > <zebra_loglevels>none,fatal,warn,request,info</zebra_loglevels> > 9 - tail -f /var/log/koha/kohadev/zebra-output.log >10 - On manage marc apply matchign with no rule, then reapply with rule >11 - View the output in the log - the index searched is 'Any' >12 - Apply patch >13 - Reapply matching >14 - Note we search the expected index and no match is found >--- > C4/AuthoritiesMarc.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm >index 293f64b..e3d3308 100644 >--- a/C4/AuthoritiesMarc.pm >+++ b/C4/AuthoritiesMarc.pm >@@ -164,7 +164,7 @@ sub SearchAuthorities { > $attr = " \@attr 1=Subject-heading-thesaurus "; > } > else { # Assume any if no index was specified >- $attr = " \@attr 1=Any "; >+ $attr = " \@attr 1=" . @$tags[$i] . " "; > } > } #if @$tags[$i] > else { # Assume any if no index was specified >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21581
:
80658
|
80665
|
81064
|
81065
|
81599
|
81600
|
81601