Attachment 80684 Details for Bug 21583 – Bug 21583: Don't use Asset.js for external script files

[patch] Bug 21583: Don't use Asset.js for external script files

Bug-21583-Dont-use-Assetjs-for-external-script-fil.patch (text/plain), 1.69 KB, created by Chris Cormack on 2018-10-17 01:02:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2018-10-17 01:02:50 UTC

Size: 1.69 KB

patch

obsolete

>From 0db0463cca3c86e5892255ab7cc3a7b8c1d8e105 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 16 Oct 2018 17:09:29 +0000
>Subject: [PATCH] Bug 21583: Don't use Asset.js for external script files
>
>To test:
>1 - Enable Novelist in staff client:
>    NovelistSelectStaffEnabled: Add
>    NovelistSelectStaffProfile: anything
>    NovelistSelectPassword: anything
>    ( these don't need to be valid, just not blank )
>2 - Pull up a record detail page in staff client
>3 - View page source - search for ns2init.js
>4 - You won't find it
>5 - Apply patch
>6 - Reload details
>7 - Search page source for ns2init.js
>8 - It loaded! Huzzah!
>
>Signed-off-by: George Williams <george@nekls.org>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index 4dddbe45a3..451c10526f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -1080,7 +1080,7 @@
>         });[% END %]
>     </script>
>     [% IF ( Koha.Preference('NovelistSelectStaffEnabled') && Koha.Preference('NovelistSelectStaffProfile') && ( normalized_isbn || normalized_upc ) ) %]
>-        [% Asset.js("https://imageserver.ebscohost.com/novelistselect/ns2init.js") | $raw %]
>+        <script src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script>
>     [% END %]
>     [% INCLUDE 'datatables.inc' %]
>     [% Asset.js("lib/jquery/plugins/jquery.dataTables.columnFilter.js") | $raw %]
>-- 
>2.19.1

Actions: View | Diff | Splinter Review

Attachments on bug 21583: 80668 | 80681 | 80684