Attachment 80761 Details for Bug 20844 – Bug 20844: Fixed error when cancelling hold from cataloguing/additem.pl

[patch] Bug 20844: Fixed error when cancelling hold from cataloguing/additem.pl

Bug-20844-Fixed-error-when-cancelling-hold-from-ca.patch (text/plain), 2.71 KB, created by Alex Buckley on 2018-10-17 21:31:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Buckley

Created: 2018-10-17 21:31:32 UTC

Size: 2.71 KB

patch

obsolete

>From 0bbb79fc7e6c80f320d954e670d4e4c2fc51f8ee Mon Sep 17 00:00:00 2001
>From: Alex Buckley <alexbuckley@catalyst.net.nz>
>Date: Wed, 17 Oct 2018 13:34:21 +0000
>Subject: [PATCH] Bug 20844: Fixed error when cancelling hold from
> cataloguing/additem.pl
>
>Also fixed qa test tool failure on C4/Circulation.pm
>
>Sponsored-By: Brimbank Library, Australia
>---
> C4/Circulation.pm                                              | 1 -
> cataloguing/additem.pl                                         | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 4 ++--
> 3 files changed, 3 insertions(+), 4 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index d7af3a7..139ccb5 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -3687,7 +3687,6 @@ sub LostItem{
> 
>     my ( $restype, $res ) = C4::Reserves::CheckReserves( $itemnumber );
>     my $LostItemLevelHold;
>-    my $transfers;
>     if ( $restype eq "Waiting" || $restype eq "Reserved" ) {
>         if ( $res->{originalholdtype} eq "B" ) {
>             #originalholdtype equalling "B" means this is a bib level hold
>diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl
>index 3661878..9d32e54 100755
>--- a/cataloguing/additem.pl
>+++ b/cataloguing/additem.pl
>@@ -717,7 +717,7 @@ if ($op eq "additem") {
>     if ($LostItemLevelHold) {
>         $lostitemnumber = $originalitemnumber;
>     }
>-    $template->param( LostItemLevelHold  => $LostItemLevelHold, itemnumber => $originalitemnumber );
>+    $template->param( LostItemLevelHold  => $LostItemLevelHold, lostitemnumber => $lostitemnumber );
>     $nextop="additem";
> } elsif ($op eq "delinkitem"){
>     my $analyticfield = '773';
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>index 862039f..4c68c97 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>@@ -263,8 +263,8 @@ function confirm_deletion() {
>     [% IF (LostItemLevelHold) %]
>         <div class="alert alert-warning">
>             <form id="DeallocateLostItemLevelHold" method="post" action="/cgi-bin/koha/cataloguing/additem.pl" name="DeallocateLostItemLevelHold">
>-                <input type="hidden" id="itemnumber" name="itemnumber" value="[% itemnumber %]"/>
>-                This item has an item-level hold on it:
>+                <input type="hidden" id="itemnumber" name="itemnumber" value="[% lostitemnumber | html %]"/>
>+                This item has an item-level hold on [% itemnumber | html %] it:
>                 <input type="submit" name="RetainHold" value="Retain Hold"/>
>                 <input type="submit" name="CancelHold" value="Cancel hold"/>
>             </form>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20844: 79267 | 80760 | 80761 | 80890 | 80891 | 81045 | 81531 | 81623 | 81624 | 81640 | 81697 | 81698 | 81710 | 81711 | 81712 | 102334 | 102335 | 102336 | 113208 | 113209 | 113210 | 118264 | 118265 | 118266 | 125437 | 125438 | 125439 | 140214 | 140215 | 140216 | 150348 | 150349 | 150350 | 150480 | 159062 | 159063 | 159064 | 159065 | 159111 | 170263 | 170264