Attachment 80799 Details for Bug 21587 – Bug 21587: don't drop patrons to notify in order creation

[patch] Bug 21587: don't drop patrons to notify in order creation

Bug-21587-dont-drop-patrons-to-notify-in-order-cre.patch (text/plain), 1.69 KB, created by Victor Grousset/tuxayo on 2018-10-18 10:04:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2018-10-18 10:04:18 UTC

Size: 1.69 KB

patch

obsolete

>From 88c2d554ef3a662eb2e0bde666b652b192a1c5e5 Mon Sep 17 00:00:00 2001
>From: Victor Grousset <victor.grousset@biblibre.com>
>Date: Thu, 18 Oct 2018 11:54:58 +0200
>Subject: [PATCH] Bug 21587: don't drop patrons to notify in order creation
>
>It only worked on modification.
>
>== Test plan ==
>1. have/create a active budget
>2. have/create a fund
>3. have/create a vendor with minimal info
>4. create a basket with minimal info
>5. add an order line to the basket
>     Add a user in "To notify on receiving"
>6. Modify the order
>7. The patrons isn't here. This is the bug
>8. Add a user in "To notify on receiving"
>9. Save
>10. Modify the order
>11. The patron is here now
>12. Apply this patch
>13. Retry step 5 to 11 and patron should be saved on order creation
>14. Celebrate! :D
>---
> acqui/addorder.pl | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
>diff --git a/acqui/addorder.pl b/acqui/addorder.pl
>index 17b50e6..2c269e0 100755
>--- a/acqui/addorder.pl
>+++ b/acqui/addorder.pl
>@@ -290,14 +290,13 @@ if ( $basket->{is_standing} || $orderinfo->{quantity} ne '0' ) {
>     my $order = Koha::Acquisition::Order->new($orderinfo);
>     if ( $orderinfo->{ordernumber} ) {
>         ModOrder($orderinfo);
>-        my $order_users_ids = $input->param('users_ids');
>-        my @order_users = split( /:/, $order_users_ids );
>-
>-        ModOrderUsers( $orderinfo->{ordernumber}, @order_users );
>     }
>     else { # else, it's a new line
>         $order->store;
>     }
>+    my $order_users_ids = $input->param('users_ids');
>+    my @order_users = split( /:/, $order_users_ids );
>+    ModOrderUsers( $order->ordernumber, @order_users );
> 
>     # now, add items if applicable
>     if ($basket->effective_create_items eq 'ordering') {
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 21587: 80799 | 81166 | 81293 | 85692