Bugzilla – Attachment 80803 Details for
Bug 21593
Remove Group by clause in GetAuthValueDropbox
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21593: Remove GROUP BY from GetAuthValueDropbox
Bug-21593-Remove-GROUP-BY-from-GetAuthValueDropbox.patch (text/plain), 1.25 KB, created by
Martin Renvoize (ashimema)
on 2018-10-18 11:17:44 UTC
(
hide
)
Description:
Bug 21593: Remove GROUP BY from GetAuthValueDropbox
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2018-10-18 11:17:44 UTC
Size:
1.25 KB
patch
obsolete
>From 17ea2bc0927bd39b13065c7bb437093f39751f92 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 18 Oct 2018 10:05:38 +0000 >Subject: [PATCH] Bug 21593: Remove GROUP BY from GetAuthValueDropbox > >With new MYSQL modes we are permitted only full group by. > >In this case I don't think we need a GROUP BY at all > >To test: >1 - Try to pay a fine or create a borrower >2 - Internal server error >3 - Apply patch >4 - Page should load >5 - Test various authorised values ot ensure they work > e.g. Set bsort1 and bsort2 to have some authorised values with and > without branch limits > set PAYMENT_TYPE to have some values with and without branch limits > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Template/Plugin/AuthorisedValues.pm | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/Koha/Template/Plugin/AuthorisedValues.pm b/Koha/Template/Plugin/AuthorisedValues.pm >index 2692c15a06..95b0c4c939 100644 >--- a/Koha/Template/Plugin/AuthorisedValues.pm >+++ b/Koha/Template/Plugin/AuthorisedValues.pm >@@ -48,7 +48,6 @@ sub GetAuthValueDropbox { > category => $category, > }, > { >- group_by => 'lib', > order_by => [ 'category', 'lib', 'lib_opac' ], > } > ); >-- >2.19.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21593
:
80800
| 80803