Attachment 80836 Details for Bug 21598 – Bug 21598: 'koha_kohadev.aqbudgets.budget_parent_id' isn't in GROUP BY

[patch] Bug 21598: 'koha_kohadev.aqbudgets.budget_parent_id' isn't in GROUP BY

Bug-21598-kohakohadevaqbudgetsbudgetparentid-isnt-.patch (text/plain), 1.69 KB, created by Martin Renvoize (ashimema) on 2018-10-18 13:17:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2018-10-18 13:17:24 UTC

Size: 1.69 KB

patch

obsolete

>From c6b4c327415be01ccbbcb90876e540dc6506c83a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 17 Oct 2018 19:31:14 -0300
>Subject: [PATCH] Bug 21598: 'koha_kohadev.aqbudgets.budget_parent_id' isn't in
> GROUP BY
>
>DBD::mysql::db selectall_hashref failed:
>'koha_kohadev.aqbudgets.budget_parent_id' isn't in GROUP BY [for
>Statement "
>
>    at /home/vagrant/kohaclone/C4/Budgets.pm line 558.
>and
>    at /home/vagrant/kohaclone/C4/Budgets.pm line 565.
>
>Test plan:
>hit /cgi-bin/koha/admin/aqbudgets.pl
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/Budgets.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Budgets.pm b/C4/Budgets.pm
>index caacd7cd9c..b97e19db37 100644
>--- a/C4/Budgets.pm
>+++ b/C4/Budgets.pm
>@@ -560,14 +560,14 @@ sub GetBudgetHierarchy {
>                SUM( COALESCE(unitprice_tax_included, ecost_tax_included) * quantity ) AS budget_spent
>         FROM aqorders JOIN aqbudgets USING (budget_id)
>         WHERE quantityreceived > 0 AND datecancellationprinted IS NULL
>-        GROUP BY budget_id
>+        GROUP BY budget_id, budget_parent_id
>         |, 'budget_id');
>     my $hr_budget_ordered = $dbh->selectall_hashref(q|
>         SELECT aqorders.budget_id, aqbudgets.budget_parent_id,
>                SUM(ecost_tax_included *  quantity) AS budget_ordered
>         FROM aqorders JOIN aqbudgets USING (budget_id)
>         WHERE quantityreceived = 0 AND datecancellationprinted IS NULL
>-        GROUP BY budget_id
>+        GROUP BY budget_id, budget_parent_id
>         |, 'budget_id');
>     my $hr_budget_spent_shipment = $dbh->selectall_hashref(q|
>         SELECT shipmentcost_budgetid as budget_id,
>-- 
>2.19.1

Actions: View | Diff | Splinter Review

Attachments on bug 21598: 80811 | 80836