Bugzilla – Attachment 80851 Details for
Bug 20521
dev installations should run with problematic SQL modes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20521: Use a specific config for strict sql modes
Bug-20521-Use-a-specific-config-for-strict-sql-mod.patch (text/plain), 1.29 KB, created by
Jonathan Druart
on 2018-10-18 14:08:28 UTC
(
hide
)
Description:
Bug 20521: Use a specific config for strict sql modes
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-10-18 14:08:28 UTC
Size:
1.29 KB
patch
obsolete
>From 735f785b98ddb70a664f170f1e9f1f2c4e90ce48 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 18 Oct 2018 11:07:02 -0300 >Subject: [PATCH] Bug 20521: Use a specific config for strict sql modes > >To avoid dev to complain to much it will be turned off by default. >We will turn it on for Jenkins so devs will have to take care of the >regressions they introduce (!) >--- > Koha/Database.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Database.pm b/Koha/Database.pm >index 490839b99a..56ffc46488 100644 >--- a/Koha/Database.pm >+++ b/Koha/Database.pm >@@ -76,7 +76,7 @@ sub _new_schema { > %encoding_attr = ( mysql_enable_utf8 => 1 ); > $encoding_query = "set NAMES 'utf8mb4'"; > $tz_query = qq(SET time_zone = "$tz") if $tz; >- unless ( C4::Context->config('dev_install') ) { >+ unless ( C4::Context->config('strict_sql_modes') ) { > $sql_mode_query = q{SET sql_mode = 'IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'}; > } else { > $sql_mode_query = q{SET sql_mode = 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'}; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20521
:
73659
|
73670
|
73683
| 80851