Bugzilla – Attachment 80854 Details for
Bug 21597
Test suite is still failing with new default SQL modes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21597: Data too long for column 'invitekey'
Bug-21597-Data-too-long-for-column-invitekey.patch (text/plain), 1.74 KB, created by
Martin Renvoize (ashimema)
on 2018-10-18 14:12:01 UTC
(
hide
)
Description:
Bug 21597: Data too long for column 'invitekey'
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2018-10-18 14:12:01 UTC
Size:
1.74 KB
patch
obsolete
>From 8739811630cea0ca6898871fc12400ff935fadda Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 17 Oct 2018 19:18:58 -0300 >Subject: [PATCH] Bug 21597: Data too long for column 'invitekey' > >Fix t/db_dependent/Virtualshelves.t > >virtualshelfshares.invitekey > `invitekey` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > >We should not insert a longer string! > >DBIx::Class::Storage::DBI::_dbh_execute(): Data too long for column >'invitekey' at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 125 > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Virtualshelves.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Virtualshelves.t b/t/db_dependent/Virtualshelves.t >index 8b751fe1da..ce521add97 100644 >--- a/t/db_dependent/Virtualshelves.t >+++ b/t/db_dependent/Virtualshelves.t >@@ -153,9 +153,9 @@ subtest 'Sharing' => sub { > is( $number_of_shelves_shared, 2, 'To be sure no shares have been removed' ); > > # Test double accept (BZ 11943) before removing the accepted share >- my $third_share = $shelf_to_share->share('valid key number 2'); >+ my $third_share = $shelf_to_share->share('valid key3'); > is( Koha::Virtualshelfshares->search->count, 3, 'Three shares' ); >- $is_accepted = $third_share->accept( 'valid key number 2', $share_with_me->{borrowernumber} ); >+ $is_accepted = $third_share->accept( 'valid key3', $share_with_me->{borrowernumber} ); > is( $is_accepted->shelfnumber, $shelf_to_share->shelfnumber, 'Accept returned the existing share' ); > is( Koha::Virtualshelfshares->search->count, 2, 'Check that number of shares went down again' ); > >-- >2.19.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21597
:
80812
|
80813
|
80814
|
80815
|
80816
|
80821
|
80829
|
80830
|
80831
|
80832
|
80833
|
80834
|
80852
|
80853
| 80854 |
80855
|
80856
|
80857