Bugzilla – Attachment 80857 Details for
Bug 21597
Test suite is still failing with new default SQL modes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21597: Incorrect decimal value: 't_value_bib639' for column 'price'
Bug-21597-Incorrect-decimal-value-tvaluebib639-for.patch (text/plain), 1.73 KB, created by
Martin Renvoize (ashimema)
on 2018-10-18 14:12:13 UTC
(
hide
)
Description:
Bug 21597: Incorrect decimal value: 't_value_bib639' for column 'price'
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2018-10-18 14:12:13 UTC
Size:
1.73 KB
patch
obsolete
>From 6b280999d5a3a6eec0a4994d9adad56eb1d0d57f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 17 Oct 2018 20:24:09 -0300 >Subject: [PATCH] Bug 21597: Incorrect decimal value: 't_value_bib639' for > column 'price' > >Fix t/db_dependent/selenium/basic_workflow.t > >We want to send specific values depending on the data type in DB >For instance integer, or varchar(10) > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/selenium/basic_workflow.t | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/selenium/basic_workflow.t b/t/db_dependent/selenium/basic_workflow.t >index 420ca3ce76..9e9341f103 100644 >--- a/t/db_dependent/selenium/basic_workflow.t >+++ b/t/db_dependent/selenium/basic_workflow.t >@@ -160,7 +160,24 @@ SKIP: { > my $id = $input->get_attribute('id'); > next unless $id =~ m|^tag_952_subfield|; > >- $input->send_keys('t_value_bib'.$biblionumber); >+ my $v; >+ >+ # FIXME This is based on default values >+ if ( $id =~ m|^tag_952_subfield_g| # price >+ or $id =~ m|^tag_952_subfield_v| ) # replacementprice >+ { >+ $v = '42'; # It's a price >+ } >+ elsif ( >+ $id =~ m|^tag_952_subfield_f| #tag_952_subfield_g >+ ) { >+ # It's a varchar(10) >+ $v = 't_value_x'; >+ } >+ else { >+ $v = 't_value_bib' . $biblionumber; >+ } >+ $input->send_keys( $v ); > } > > $driver->find_element('//input[@name="add_submit"]')->click; >-- >2.19.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21597
:
80812
|
80813
|
80814
|
80815
|
80816
|
80821
|
80829
|
80830
|
80831
|
80832
|
80833
|
80834
|
80852
|
80853
|
80854
|
80855
|
80856
| 80857