Bugzilla – Attachment 80865 Details for
Bug 21568
Add more spans with classes around callnumbers in OPAC for additional styling
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21568: Add more spans with classes around callnumbers in OPAC for additional styling
Bug-21568-Add-more-spans-with-classes-around-calln.patch (text/plain), 3.09 KB, created by
Tomás Cohen Arazi (tcohen)
on 2018-10-18 16:26:13 UTC
(
hide
)
Description:
Bug 21568: Add more spans with classes around callnumbers in OPAC for additional styling
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2018-10-18 16:26:13 UTC
Size:
3.09 KB
patch
obsolete
>From 730e5883c7f73544bbae5c86164c6beb6507ffa1 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 15 Oct 2018 06:36:51 -0400 >Subject: [PATCH] Bug 21568: Add more spans with classes around callnumbers in > OPAC for additional styling > >It would be nice if the callnumber portion of the callnumber + label was in a span, >and it also makes sense to wrap the entire callnumber string in a span as well. >This was started on bug 21340 but I have found more callnumbers in the search results that need spans. > >Test Plan: >1) Apply this patch >2) Search for something in the OAPC with multiple results >3) View the HTML source >4) Note the new spans around the callnumbers, like: <span class="CallNumber" > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > .../opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >index e98d3de47b..8de998361d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >@@ -1323,7 +1323,7 @@ > <xsl:when test="$OPACItemLocation='location'"><b><xsl:value-of select="concat(items:location,' ')"/></b></xsl:when> > <xsl:when test="$OPACItemLocation='ccode'"><b><xsl:value-of select="concat(items:ccode,' ')"/></b></xsl:when> > </xsl:choose> >- <xsl:if test="items:itemcallnumber != '' and items:itemcallnumber"> <xsl:value-of select="items:itemcallnumber"/></xsl:if> >+ <xsl:if test="items:itemcallnumber != '' and items:itemcallnumber"><span class="CallNumber"><xsl:value-of select="items:itemcallnumber"/></span></xsl:if> > <xsl:choose><xsl:when test="position()=last()"><xsl:text>. </xsl:text></xsl:when><xsl:otherwise><xsl:text>, </xsl:text></xsl:otherwise></xsl:choose> > </xsl:for-each> > </span> >@@ -1336,7 +1336,7 @@ > <xsl:when test="$OPACItemLocation='location'"><b><xsl:value-of select="concat(items:location,' ')"/></b></xsl:when> > <xsl:when test="$OPACItemLocation='ccode'"><b><xsl:value-of select="concat(items:ccode,' ')"/></b></xsl:when> > </xsl:choose> >- <xsl:if test="items:itemcallnumber != '' and items:itemcallnumber"> <xsl:value-of select="items:itemcallnumber"/></xsl:if> >+ <xsl:if test="items:itemcallnumber != '' and items:itemcallnumber"><span class="CallNumber"><xsl:value-of select="items:itemcallnumber"/></span></xsl:if> > <xsl:choose><xsl:when test="position()=last()"><xsl:text>. </xsl:text></xsl:when><xsl:otherwise><xsl:text>, </xsl:text></xsl:otherwise></xsl:choose> > </xsl:for-each> > </span> >-- >2.19.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21568
:
80588
|
80589
| 80865