Attachment 8092 Details for Bug 7645 – [Signed-off] Bug 7645 - System preferences editor save button obscured by language chooser

[patch] [Signed-off] Bug 7645 - System preferences editor save button obscured by language chooser

0001-Bug-7645-System-preferences-editor-save-button-obscu.patch (text/plain), 2.38 KB, created by Julian Maurice on 2012-03-08 14:49:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2012-03-08 14:49:46 UTC

Size: 2.38 KB

patch

obsolete

>From fdb31db9e39c5eee499010cdd4665967a5104c6c Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 5 Mar 2012 12:38:00 -0500
>Subject: [PATCH] Bug 7645 - System preferences editor save button obscured by
> language chooser
>
>This patch amends the preferences page's CSS file to add
>bottom padding to the page container. This gives the bottom-
>most submit button some breathing room.
>
>Markup correction: Adding "row" and "col" attributes to
><textareas> to quiet validation errors. This doesn't
>affect output at all (dimensions are specified in CSS).
>
>To test, open the system preferences page to a tab like OPAC
>which contains many preferences. At the bottom of the page
>the last submit button should have about a line's worth of
>white space below it.
>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>---
> .../intranet-tmpl/prog/en/css/preferences.css      |    4 ++++
> .../prog/en/modules/admin/preferences.tt           |    2 +-
> 2 files changed, 5 insertions(+), 1 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/preferences.css b/koha-tmpl/intranet-tmpl/prog/en/css/preferences.css
>index d9fde24..262fe11 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/css/preferences.css
>+++ b/koha-tmpl/intranet-tmpl/prog/en/css/preferences.css
>@@ -65,4 +65,8 @@ h3.collapsed {
> .humanMsg strong {
> 	display: block;
> 	font-weight: normal;
>+}
>+
>+#yui-main {
>+	margin-bottom:2em;
> }
>\ No newline at end of file
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
>index d762be7..ed2a964 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
>@@ -98,7 +98,7 @@
>                     </select>
>                     [% ELSIF ( CHUNK.type_textarea ) %]
> 					<a class="expand-textarea" style="display: none" href="#">Click to Edit</a>
>-					<textarea name="pref_[% CHUNK.name %]" id="pref_[% CHUNK.name %]" class="preference preference-[% CHUNK.class or "short" %]">[% CHUNK.value %]</textarea>
>+					<textarea name="pref_[% CHUNK.name %]" id="pref_[% CHUNK.name %]" class="preference preference-[% CHUNK.class or "short" %]" rows="10" cols="40">[% CHUNK.value %]</textarea>
>                     [% ELSIF ( CHUNK.type_languages ) %]
>                     <dl>
>                     [% FOREACH language IN CHUNK.languages %]
>-- 
>1.7.9.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 7645: 8017 | 8019 | 8092