Attachment 80949 Details for Bug 21621 – Bug 21621: Remove incorrect GROUP BY from tools/letter.pl

[patch] Bug 21621: Remove incorrect GROUP BY from tools/letter.pl

Bug-21621-Remove-incorrect-GROUP-BY-from-toolslett.patch (text/plain), 1.36 KB, created by Pierre-Marc Thibault on 2018-10-19 18:13:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pierre-Marc Thibault

Created: 2018-10-19 18:13:11 UTC

Size: 1.36 KB

patch

obsolete

>From c12bb1e21bf5d79b7fda99f077878bc5cb830a4e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 19 Oct 2018 12:06:43 -0300
>Subject: [PATCH] Bug 21621: Remove incorrect GROUP BY from tools/letter.pl
>
>Fix:
>  'koha_kohadev.letter.name' isn't in GROUP BY
>
>DBD::mysql::db selectall_arrayref failed: 'koha_kohadev.letter.name' isn't in GROUP BY [for Statement "SELECT branchcode, module, code, name, branchname
>            FROM letter
>            LEFT OUTER JOIN branches USING (branchcode)
>     GROUP BY branchcode,module,code ORDER BY module, code, branchcode"] at /home/vagrant/kohaclone/tools/letter.pl line 383.
>
>Test plan:
>- Copy some default notice templates for specific libraries
>- List the different notice templates
>- Confirm that notices appear only one, with "all libraries" you will see all
>
>Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
>---
> tools/letter.pl | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/tools/letter.pl b/tools/letter.pl
>index d1c95bc..caaeb0e 100755
>--- a/tools/letter.pl
>+++ b/tools/letter.pl
>@@ -377,7 +377,6 @@ sub retrieve_letters {
>     }
> 
>     $sql .= " WHERE ".join(" AND ", @where) if @where;
>-    $sql .= " GROUP BY branchcode,module,code";
>     $sql .= " ORDER BY module, code, branchcode";
> 
>     return $dbh->selectall_arrayref($sql, { Slice => {} }, @args);
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 21621: 80942 | 80949 | 81366