Attachment 81023 Details for Bug 21634 – Bug 21634: Keep "circulation" module selected when viewing patron's logs

[patch] Bug 21634: Keep "circulation" module selected when viewing patron's logs

Bug-21634-Keep-circulation-module-selected-when-vi.patch (text/plain), 2.20 KB, created by Jonathan Druart on 2018-10-23 13:17:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-10-23 13:17:32 UTC

Size: 2.20 KB

patch

obsolete

>From 134a40339b9077b4d5e938817692ebb2da1f2d90 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 23 Oct 2018 10:15:11 -0300
>Subject: [PATCH] Bug 21634: Keep "circulation" module selected when viewing
> patron's logs
>
>To recreate:
>- View a patron detail page
>- Click "Modification log"
>- Notice that the url has "modules=MEMBERS&amp;modules=circulation", but
>the "Circulation" option is not selected in the "Modules" dropdown list.
>This is because of uppercase vs lowercase.
>
>The bug:
>- Right after you click "Modification log" you will see all the
>"members" and "circulation" logs
>- Submit the form without changing any input/select from the form
>=> Now you only see the "members" logs.
>
>Test plan:
>- Apply the patch
>- Click "Modification log"
>- Notice that the url now contains "modules=MEMBERS&amp;modules=CIRCULATION"
>- Submit the form without changing any input/select from the form
>=> Now you have the "members" and "circulation" modules selected.
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>index a69d099e92..6896867cb3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
>@@ -98,7 +98,7 @@
>         [% END %]
>     [% END %]
>     [% IF ( CAN_user_tools_view_system_logs ) %]
>-        [% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&amp;modules=MEMBERS&amp;modules=circulation&amp;object=[% patron.borrowernumber | html %]&amp;src=circ">Modification log</a></li>
>+        [% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&amp;modules=MEMBERS&amp;modules=CIRCULATION&amp;object=[% patron.borrowernumber | html %]&amp;src=circ">Modification log</a></li>
>     [% END %]
>     [% IF CAN_user_borrowers_edit_borrowers %]
>     [% IF ( sentnotices ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/notices.pl?borrowernumber=[% patron.borrowernumber | html %]">Notices</a></li>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21634: 81023 | 81335 | 81336 | 81401