Attachment 81047 Details for Bug 21476 – Bug 21476: [alternate] Incorrect filter prevents HTML5 media from playing in the OPAC

[patch] Bug 21476: [alternate] Incorrect filter prevents HTML5 media from playing in the OPAC

Bug-21476-alternate-Incorrect-filter-prevents-HTML.patch (text/plain), 2.15 KB, created by Alex Buckley on 2018-10-24 05:14:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Buckley

Created: 2018-10-24 05:14:33 UTC

Size: 2.15 KB

patch

obsolete

>From 63839b8e039207dd979417bc23219d4b8a2f8834 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 23 Oct 2018 12:30:25 +0000
>Subject: [PATCH] Bug 21476: [alternate] Incorrect filter prevents HTML5 media
> from playing in the OPAC
>
>This patch makes a correction to a template filter to prevent
>incorrectly-encoded HTML in media source links which were preventing
>media from embedding correctly in the OPAC.
>
>To test, apply the patch and enable the HTML5MediaEnabled and
>HTML5MediaYouTube system preferences.
>
>- Edit a record to include links to videos in 856$u. For example:
>  - https://www.youtube.com/watch?v=grTwH6Evdfc
>    - https://archive.org/download/POPEYEMeetsSindbadTheSailor1936/POPEYE%20meets%20Sindbad%20The%20Sailor%20%281936%29.ogv
>
>    View the record in the OPAC and confirm that the videos display in
>    the
>    "Play media" tab and that they play correctly.
>
>Tested and works as described, also matches the intranet code.
>
>Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index c451d8d..d465a2c 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -1005,7 +1005,7 @@
>                                 <p>
>                                   [% SET ctrl_preload = ' controls preload=none' #translatability %]
>                                   <[% HTML5MediaParent _ ctrl_preload | html %] >
>-                                    <[% HTML5MediaSet.child _ ' src="' _  HTML5MediaSet.srcblock _'"' _ HTML5MediaSet.typeblock | html %] />
>+                                    <[% HTML5MediaSet.child | html %] src="[% HTML5MediaSet.srcblock | html %]" [% HTML5MediaSet.typeblock | html %] />
>                                     <span>[[% HTML5MediaParent | html %] tag not supported by your browser.]</span>
>                                   </[% HTML5MediaParent | html %]>
>                                 </p>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 21476: 80932 | 81013 | 81047 | 81713 | 81714 | 81721 | 81780