Bugzilla – Attachment 81048 Details for
Bug 21584
Wrong offset type for Lost Item
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21584: Wrong offset type for Lost Item
Bug-21584-Wrong-offset-type-for-Lost-Item.patch (text/plain), 1.92 KB, created by
Alex Buckley
on 2018-10-24 05:41:44 UTC
(
hide
)
Description:
Bug 21584: Wrong offset type for Lost Item
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2018-10-24 05:41:44 UTC
Size:
1.92 KB
patch
obsolete
>From fbed2849ae52e13dbbabc068cb434dbee85bd972 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 16 Oct 2018 15:15:10 -0300 >Subject: [PATCH] Bug 21584: Wrong offset type for Lost Item > >Bug 2696 introduced account_offset_type.inc but 'Lost Item Return' doesn't match what is added on the database. Moreover, bug 20978 added references to this wrong value too in Koha::Account > >This patch performs a trivial fix for this. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Patch matches what was outlined in test plan, also passes qa test tool > >Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> >--- > Koha/Account.pm | 2 +- > koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Account.pm b/Koha/Account.pm >index 2db8d0d..e686397 100644 >--- a/Koha/Account.pm >+++ b/Koha/Account.pm >@@ -535,7 +535,7 @@ sub non_issues_charges { > our $offset_type = { > 'credit' => 'Manual Credit', > 'forgiven' => 'Writeoff', >- 'lost_item_return' => 'Lost Item Return', >+ 'lost_item_return' => 'Lost Item', > 'payment' => 'Payment', > 'writeoff' => 'Writeoff' > }; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc >index aecb415..94edb23 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc >@@ -3,7 +3,7 @@ > [% CASE 'Payment' %]Payment > [% CASE 'Manual Credit' %]Manual credit > [% CASE 'Manual Debit' %]Manual invoice >- [% CASE 'Lost Item Return' %]Lost item returned >+ [% CASE 'Lost Item' %]Lost item returned > [% CASE 'Writeoff' %]Writeoff > [% CASE 'Void Payment' %]Void payment > [% CASE %][% account_offset.type | html %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21584
:
80676
|
81048
|
81057