Bugzilla – Attachment 81070 Details for
Bug 15766
Give label and patron card batches a description
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15766: Fix incorrect GROUP BY
Bug-15766-Fix-incorrect-GROUP-BY.patch (text/plain), 1002 bytes, created by
Jonathan Druart
on 2018-10-24 14:52:00 UTC
(
hide
)
Description:
Bug 15766: Fix incorrect GROUP BY
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-10-24 14:52:00 UTC
Size:
1002 bytes
patch
obsolete
>From 84c59f0fbcc93886aaf6c131b649ac87c4b17d8a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 24 Oct 2018 11:51:12 -0300 >Subject: [PATCH] Bug 15766: Fix incorrect GROUP BY > >'koha_kohadev.creator_batches.description' isn't in GROUP BY > >Fix t/db_dependent/Creators/Lib.t if strict sql modes is on >--- > C4/Creators/Lib.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Creators/Lib.pm b/C4/Creators/Lib.pm >index 68e6aa5930..c16a2c81a6 100644 >--- a/C4/Creators/Lib.pm >+++ b/C4/Creators/Lib.pm >@@ -295,7 +295,7 @@ sub get_batch_summary { > my @batches = (); > $params->{fields} = ['batch_id', 'description', 'count(batch_id) as _item_count']; > my ( $query, @where_args ) = _build_query( $params, 'creator_batches' ); >- $query .= " GROUP BY batch_id"; >+ $query .= " GROUP BY batch_id, description"; > my $sth = C4::Context->dbh->prepare($query); > $sth->execute( @where_args ); > if ($sth->err) { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15766
:
59994
|
59998
|
59999
|
61462
|
61463
|
61464
|
63221
|
63222
|
63223
|
66515
|
67305
|
67862
|
68282
|
68359
|
68360
|
68361
|
68362
|
75213
|
75214
|
75215
|
75216
|
75715
|
75843
|
79839
|
79840
|
79841
|
79842
|
79843
|
79844
|
79845
|
79846
|
80446
|
80447
|
80448
|
80449
|
80450
|
80451
| 81070 |
81084
|
81086