Bugzilla – Attachment 81182 Details for
Bug 21186
Incorrect Bootstrap modal event name in multiple templates
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21186: (follow-up) Incorrect Bootstrap modal event name in multiple templates
Bug-21186-follow-up-Incorrect-Bootstrap-modal-even.patch (text/plain), 3.45 KB, created by
Owen Leonard
on 2018-10-25 15:37:42 UTC
(
hide
)
Description:
Bug 21186: (follow-up) Incorrect Bootstrap modal event name in multiple templates
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2018-10-25 15:37:42 UTC
Size:
3.45 KB
patch
obsolete
>From 82fd024e565b05c2a5051f638c06aaba27b4044f Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 25 Oct 2018 15:24:29 +0000 >Subject: [PATCH] Bug 21186: (follow-up) Incorrect Bootstrap modal event name > in multiple templates > >This patch addresses a few more instances of this problem which I didn't >catch in my first pass. > >To test, apply the patch and clear your browser cache if necessary. > >- Go to Circulation -> Check in and check in an item which has a hold. > - When the 'Hold found' modal appears the checkin barcode field > behind it should be disabled. > - When the modal is dismissed the checkin field should be enabled > again and focus should be on that field. > >- Go to Administration -> Library groups. > - Click the "Add group" button. The cursor focus should be on the > title field. > >- Go to Tools -> MARC modification templates. > - Click the "New template" button. The cursor focus should be on the > name field. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt >index 96be4ec..b69857d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt >@@ -53,7 +53,7 @@ > $('#add-group-modal-description').val(""); > $('#add-group-modal-title').val(""); > >- $('#add-group-modal').on('shown', function() { >+ $('#add-group-modal').on('shown.bs.modal', function() { > $('#add-group-modal-title').focus(); > }); > >@@ -85,7 +85,7 @@ > $('#root-group-features-edit').show(); > } > >- $('#edit-group-modal').on('shown', function() { >+ $('#edit-group-modal').on('shown.bs.modal', function() { > $('#edit-group-modal-title').focus(); > }); > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 5763e97..854465d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -757,9 +757,9 @@ > $("#barcode").focus(); > } > $(document).ready(function () { >- $(".modal").modal({ backdrop: 'static' }).on('shown', function() { >+ $(".modal").modal({ backdrop: 'static' }).on('shown.bs.modal', function() { > $("#barcode").prop("disabled", true); >- }).on('hidden', function() { >+ }).on('hidden.bs.modal', function() { > $("#barcode").prop("disabled", false).focus(); > }); > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js b/koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js >index 93b2a43..ca08409 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js >@@ -61,7 +61,7 @@ $(document).ready(function() { > $("#duplicate_current_template").val(1); > }); > >- $('#createTemplate').on('shown', function (e) { >+ $('#createTemplate').on('shown.bs.modal', function (e) { > e.preventDefault(); > $("#template_name").focus(); > }); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21186
:
77630
|
78412
|
81182
|
81189
|
81190
|
81369
|
81370