Bugzilla – Attachment 81186 Details for
Bug 21656
Syntax Error in Stock Rotation Default Notice Template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21656: Followup to fix atomicupdate
Bug-21656-Followup-to-fix-atomicupdate.patch (text/plain), 2.67 KB, created by
Jonathan Druart
on 2018-10-25 16:37:11 UTC
(
hide
)
Description:
Bug 21656: Followup to fix atomicupdate
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-10-25 16:37:11 UTC
Size:
2.67 KB
patch
obsolete
>From c3ac621bcc766d2ed12e37c58944b0a8bbd07e5d Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 25 Oct 2018 15:30:10 +0000 >Subject: [PATCH] Bug 21656: Followup to fix atomicupdate > >The atomicupdate is going to run as part of an upgrade. >It needs to UPDATE, not INSERT. Also, the atomicupdate >was numbered incorrectly. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > installer/data/mysql/atomicupdate/bug_21620.perl | 10 ---------- > installer/data/mysql/atomicupdate/bug_21656.perl | 8 ++++++++ > 2 files changed, 8 insertions(+), 10 deletions(-) > delete mode 100644 installer/data/mysql/atomicupdate/bug_21620.perl > create mode 100644 installer/data/mysql/atomicupdate/bug_21656.perl > >diff --git a/installer/data/mysql/atomicupdate/bug_21620.perl b/installer/data/mysql/atomicupdate/bug_21620.perl >deleted file mode 100644 >index d0caab37a0..0000000000 >--- a/installer/data/mysql/atomicupdate/bug_21620.perl >+++ /dev/null >@@ -1,10 +0,0 @@ >-$DBversion = 'XXX'; # will be replaced by the RM >-if( CheckVersion( $DBversion ) ) { >- $dbh->do(q{ >- INSERT IGNORE INTO `letter` (`module`, `code`, `branchcode`, `name`, `is_html`, `title`, `content`, `message_transport_type`) >- VALUES ('circulation', 'SR_SLIP', '', 'Stock Rotation Slip', 0, 'Stockrotation Report', 'Stockrotation report for [% branch.name %]:\r\n\r\n[% IF branch.items.size %][% branch.items.size %] items to be processed for this branch.\r\n[% ELSE %]No items to be processed for this branch\r\n[% END %][% FOREACH item IN branch.items %][% IF item.reason != \'in-demand\' %]Title: [% item.title %]\r\nAuthor: [% item.author %]\r\nCallnumber: [% item.callnumber %]\r\nLocation: [% item.location %]\r\nBarcode: [% item.barcode %]\r\nOn loan?: [% item.onloan %]\r\nStatus: [% item.reason %]\r\nCurrent Library: [% item.branch.branchname %] [% item.branch.branchcode %]\r\n\r\n[% END %][% END %]', 'email'); >- }); >- >- print "Upgrade to $DBversion done (Bug 21620 - Stock Rotation Notice, Template Toolkit Syntax Correction)\n"; >- SetVersion( $DBversion ); >-} >diff --git a/installer/data/mysql/atomicupdate/bug_21656.perl b/installer/data/mysql/atomicupdate/bug_21656.perl >new file mode 100644 >index 0000000000..1b7285625f >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_21656.perl >@@ -0,0 +1,8 @@ >+$DBversion = 'XXX'; # will be replaced by the RM >+if( CheckVersion( $DBversion ) ) { >+ $dbh->do(q{ >+ UPDATE letter SET content = REPLACE(content,"item.reason ne \'in-demand\'","item.reason != \'in-demand\'"); >+ }); >+ print "Upgrade to $DBversion done (Bug 21656 - Stock Rotation Notice, Template Toolkit Syntax Correction)\n"; >+ SetVersion( $DBversion ); >+} >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21656
:
81109
|
81181
|
81185
|
81186
|
81187
|
81188
|
81275
|
81276
|
81277
|
81278
|
81868
|
81869
|
81870
|
81871