Attachment 81261 Details for Bug 21612 – Bug 21612: Remove incorrect GROUP BY's from Koha::VirtualShelves

[patch] Bug 21612: Remove incorrect GROUP BY's from Koha::VirtualShelves

Bug-21612-Remove-incorrect-GROUP-BYs-from-KohaVirt.patch (text/plain), 1.83 KB, created by Marcel de Rooy on 2018-10-26 09:50:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2018-10-26 09:50:12 UTC

Size: 1.83 KB

patch

obsolete

>From 70cc627a7f3e3b15b4fa738b42cbae5ebc7abbfe Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 18 Oct 2018 17:37:35 -0300
>Subject: [PATCH] Bug 21612: Remove incorrect GROUP BY's from
> Koha::VirtualShelves
>Content-Type: text/plain; charset=utf-8
>
>'koha_kohadev.me.shelfname' isn't in GROUP BY
>
>Same as
>  commit 7e220e0d8f107cce63f32bfaa1919c04b4dea6e2
>  Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record
>
>Test plan:
>- Add public and privates shelves
>- Shares some of them
>- List them
>=> The correct numbers of shelves must be displayed
>
>Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/Virtualshelves.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/Koha/Virtualshelves.pm b/Koha/Virtualshelves.pm
>index bb7db67..d465ba8 100644
>--- a/Koha/Virtualshelves.pm
>+++ b/Koha/Virtualshelves.pm
>@@ -55,7 +55,7 @@ sub get_private_shelves {
>         },
>         {
>             join => [ 'virtualshelfshares' ],
>-            group_by => 'shelfnumber',
>+            distinct => 'shelfnumber',
>             order_by => 'shelfname',
>             ( ( $page and $rows ) ? ( page => $page, rows => $rows ) : () ),
>         }
>@@ -73,7 +73,7 @@ sub get_public_shelves {
>             category => 2,
>         },
>         {
>-            group_by => 'shelfnumber',
>+            distinct => 'shelfnumber',
>             order_by => 'shelfname',
>             ( ( $page and $rows ) ? ( page => $page, rows => $rows ) : () ),
>         }
>@@ -116,7 +116,7 @@ sub get_some_shelves {
>         },
>         {
>             join => [ 'virtualshelfshares' ],
>-            group_by => 'shelfnumber',
>+            distinct => 'shelfnumber',
>             order_by => { -desc => 'lastmodified' },
>         }
>     );
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 21612: 80883 | 81164 | 81261