Attachment 81271 Details for Bug 21611 – Bug 21611: Fix priority dropdown for holds

[patch] Bug 21611: Fix priority dropdown for holds

Bug-21611-Fix-priority-dropdown-for-holds.patch (text/plain), 2.25 KB, created by Martin Renvoize (ashimema) on 2018-10-26 10:32:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2018-10-26 10:32:55 UTC

Size: 2.25 KB

patch

obsolete

>From a899fe2ba67443c4429e114098f0cb1792440cd7 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 25 Oct 2018 11:29:28 +0000
>Subject: [PATCH] Bug 21611: Fix priority dropdown for holds
>
>To Test:
> 1 - Find a record
> 2 - Place several holds some with differing pickup locations
> 3 - Check in one hold to confirm as waiting
> 4 - Check another in to set a hold in transit
> 5 - View the holds queue for the record:
>    /cgi-bin/koha/reserve/request.pl?biblionumber=##
> 6 - Confirm found holds are incorrect
> 7 - Apply patch
> 8 - Reload
> 9 - Confirm holds look correct
>10 - Alter the values of HoldsSplitQueue and HoldsSplitQueueNumbering
>11 - Confirm things still look right
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
>index a04d1e0095..25af3b94e0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
>@@ -49,12 +49,15 @@
>                                 [% END %]
>                             [% END %]
>                         [% ELSE %]
>+                            [% SET ranker = 1 %]
>                             [% FOREACH h IN holds %]
>+                                [% NEXT IF h.found %]
>                                 [% IF ( h.priority == hold.priority ) %]
>-                                    <option value="[% h.priority | html %]" selected="selected">[% loop.index + 1 | html %]</option>
>+                                    <option value="[% h.priority | html %]" selected="selected">[% ranker | html %]</option>
>                                 [% ELSE %]
>-                                    <option value="[% h.priority | html %]">[% loop.index + 1 | html %]</option>
>+                                    <option value="[% h.priority | html %]">[% ranker | html %]</option>
>                                 [% END %]
>+                                [% ranker = ranker + 1 %]
>                             [% END %]
>                         [% END %]
>                     [% ELSIF !hold.found %]
>-- 
>2.19.1

Actions: View | Diff | Splinter Review

Attachments on bug 21611: 81130 | 81271 | 81382