Bugzilla – Attachment 81330 Details for
Bug 21681
Remove C4::Accounts::getcharges
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21681: Add tests for GetPatronInfo
Bug-21681-Add-tests-for-GetPatronInfo.patch (text/plain), 2.09 KB, created by
Martin Renvoize (ashimema)
on 2018-10-26 18:48:27 UTC
(
hide
)
Description:
Bug 21681: Add tests for GetPatronInfo
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2018-10-26 18:48:27 UTC
Size:
2.09 KB
patch
obsolete
>From 67dcf20918688de117566a53dd9ac36684761ba5 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 26 Oct 2018 15:25:09 -0300 >Subject: [PATCH] Bug 21681: Add tests for GetPatronInfo > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/ILSDI_Services.t | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/ILSDI_Services.t b/t/db_dependent/ILSDI_Services.t >index 9b6908ff12..f38562709c 100644 >--- a/t/db_dependent/ILSDI_Services.t >+++ b/t/db_dependent/ILSDI_Services.t >@@ -103,7 +103,7 @@ subtest 'AuthenticatePatron test' => sub { > > subtest 'GetPatronInfo/GetBorrowerAttributes test for extended patron attributes' => sub { > >- plan tests => 2; >+ plan tests => 4; > > $schema->storage->txn_begin; > >@@ -191,7 +191,7 @@ subtest 'GetPatronInfo/GetBorrowerAttributes test for extended patron attributes > } > } ); > >- $builder->build( >+ my $fine = $builder->build( > { > source => 'Accountline', > value => { >@@ -208,6 +208,7 @@ subtest 'GetPatronInfo/GetBorrowerAttributes test for extended patron attributes > $query->param( 'service', 'GetPatronInfo' ); > $query->param( 'patron_id', $brwr->{'borrowernumber'} ); > $query->param( 'show_attributes', '1' ); >+ $query->param( 'show_fines', '1' ); > > my $reply = C4::ILSDI::Services::GetPatronInfo( $query ); > >@@ -225,6 +226,13 @@ subtest 'GetPatronInfo/GetBorrowerAttributes test for extended patron attributes > is( $reply->{'charges'}, '10.00', > 'The \'charges\' attribute should be correctly filled (bug 17836)' ); > >+ is( scalar( @{$reply->{fines}->{fine}}), 1, 'There should be only 1 account line'); >+ is( >+ $reply->{fines}->{fine}->[0]->{accountlines_id}, >+ $fine->{accountlines_id}, >+ "The accountline should be the correct one" >+ ); >+ > # Check results: > is_deeply( $reply->{'attributes'}, [ $cmp ], 'Test GetPatronInfo - show_attributes parameter' ); > >-- >2.19.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21681
:
81269
|
81298
|
81306
|
81322
|
81325
|
81326
|
81327
|
81329
| 81330 |
81331