Bugzilla – Attachment 81410 Details for
Bug 21641
Software error when checking out an item with a charge associated with it
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21641: (follow-up) Address wrong call method
Bug-21641-follow-up-Address-wrong-call-method.patch (text/plain), 1.53 KB, created by
Tomás Cohen Arazi (tcohen)
on 2018-10-28 13:16:48 UTC
(
hide
)
Description:
Bug 21641: (follow-up) Address wrong call method
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2018-10-28 13:16:48 UTC
Size:
1.53 KB
patch
obsolete
>From e8724036b094329a961426c258028a17abd0b855 Mon Sep 17 00:00:00 2001 >From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >Date: Thu, 25 Oct 2018 14:17:59 +0100 >Subject: [PATCH] Bug 21641: (follow-up) Address wrong call method > >This patch substitutes C4::Accounts->getnextacctno for >C4::Accounts::getnextacctno since getnextacctno is only expecting to be >passed a borrowernumber > >Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > C4/Circulation.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index efb923da24..50d5e6d78f 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2851,7 +2851,7 @@ sub AddRenewal { > # Charge a new rental fee, if applicable? > my ( $charge, $type ) = GetIssuingCharges( $itemnumber, $borrowernumber ); > if ( $charge > 0 ) { >- my $accountno = C4::Accounts->getnextacctno( $borrowernumber ); >+ my $accountno = C4::Accounts::getnextacctno( $borrowernumber ); > my $manager_id = 0; > $manager_id = C4::Context->userenv->{'number'} if C4::Context->userenv; > $sth = $dbh->prepare( >@@ -3191,7 +3191,7 @@ sub AddIssuingCharge { > > # FIXME What if checkout does not exist? > >- my $nextaccntno = C4::Accounts->getnextacctno($checkout->borrowernumber); >+ my $nextaccntno = C4::Accounts::getnextacctno( $checkout->borrowernumber ); > > my $manager_id = 0; > $manager_id = C4::Context->userenv->{'number'} if C4::Context->userenv; >-- >2.19.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21641
:
81046
|
81138
|
81139
|
81140
|
81149
|
81200
|
81201
|
81408
|
81409
| 81410