Bugzilla – Attachment 81418 Details for
Bug 21242
Modification log redirects you to circulation with no borrower if 'Object' field is not populated with borrowernumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21242: If not searching for patron, move to log viewer
Bug-21242-If-not-searching-for-patron-move-to-log-.patch (text/plain), 1.47 KB, created by
Katrin Fischer
on 2018-10-28 17:02:19 UTC
(
hide
)
Description:
Bug 21242: If not searching for patron, move to log viewer
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-10-28 17:02:19 UTC
Size:
1.47 KB
patch
obsolete
>From 98c605fb33ef2ab9300446ccb252b4894e9789ec Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 17 Aug 2018 12:22:50 +0000 >Subject: [PATCH] Bug 21242: If not searching for patron, move to log viewer > >To test: >1 - Bring up a patron >2 - Click 'Modification log' >3 - Note you get borrower info >4 - Move the object field into info field >5 - Submit >6 - You are now on the 'Log viewer' page with admin options, not >borrower circ options > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > tools/viewlog.pl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/tools/viewlog.pl b/tools/viewlog.pl >index b8979ec776..2f8bc30e3e 100755 >--- a/tools/viewlog.pl >+++ b/tools/viewlog.pl >@@ -74,9 +74,9 @@ if ( $src eq 'circ' ) { > use C4::Members::Attributes qw(GetBorrowerAttributes); > my $borrowernumber = $object; > my $patron = Koha::Patrons->find( $borrowernumber ); >+ my $circ_info = 1; > unless ( $patron ) { >- print $input->redirect("/cgi-bin/koha/circ/circulation.pl?borrowernumber=$borrowernumber"); >- exit; >+ $circ_info = 0; > } > if ( C4::Context->preference('ExtendedPatronAttributes') ) { > my $attributes = GetBorrowerAttributes( $borrowernumber ); >@@ -88,7 +88,7 @@ if ( $src eq 'circ' ) { > > $template->param( > patron => $patron, >- circulation => 1, >+ circulation => $circ_info, > ); > } > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21242
:
77975
|
77990
|
77994
| 81418