Bugzilla – Attachment 81495 Details for
Bug 15774
Additional fields for baskets
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15774: Show additional field values in edit form
Bug-15774-Show-additional-field-values-in-edit-for.patch (text/plain), 3.52 KB, created by
Nick Clemens (kidclamp)
on 2018-10-29 13:33:58 UTC
(
hide
)
Description:
Bug 15774: Show additional field values in edit form
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2018-10-29 13:33:58 UTC
Size:
3.52 KB
patch
obsolete
>From 4eac253d812b875422e29d6cecdbf57acecf3c81 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Wed, 16 May 2018 09:30:42 +0200 >Subject: [PATCH] Bug 15774: Show additional field values in edit form >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> >--- > acqui/basketheader.pl | 2 +- > .../prog/en/modules/serials/subscription-add.tt | 4 ++-- > serials/subscription-add.pl | 17 +++++++++++++++-- > 3 files changed, 18 insertions(+), 5 deletions(-) > >diff --git a/acqui/basketheader.pl b/acqui/basketheader.pl >index da2129f..7b5b160 100755 >--- a/acqui/basketheader.pl >+++ b/acqui/basketheader.pl >@@ -100,7 +100,7 @@ if ( $op eq 'add_form' ) { > $template->param( is_an_edit => 1); > $template->param( > additional_field_values => { map { >- $_->field->name => $_->value >+ $_->field->id => $_->value > } Koha::Acquisition::Baskets->find($basketno)->additional_field_values }, > ); > } else { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >index 5248f72..32d8252 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >@@ -444,9 +444,9 @@ fieldset.rows li.radio { width: 100%; } /* override staff-global.css */ > </ol> > </fieldset> > >- [% IF additional_fields_for_subscription %] >+ [% IF additional_fields %] > <div id="subscription_additional_fields"> >- [% INCLUDE 'additional-fields-entry.inc' available=additional_fields_for_subscription values=additional_fields %] >+ [% INCLUDE 'additional-fields-entry.inc' available=additional_fields values=additional_field_values %] > </div> > [% END %] > >diff --git a/serials/subscription-add.pl b/serials/subscription-add.pl >index d9e9327..3a8534b 100755 >--- a/serials/subscription-add.pl >+++ b/serials/subscription-add.pl >@@ -64,9 +64,10 @@ my $sub_on; > my $subs; > our $firstissuedate; > >+my $subscriptionid = $query->param('subscriptionid'); >+ > if ($op eq 'modify' || $op eq 'dup' || $op eq 'modsubscription') { > >- my $subscriptionid = $query->param('subscriptionid'); > $subs = GetSubscription($subscriptionid); > > output_and_exit( $query, $cookie, $template, 'unknown_subscription') >@@ -137,7 +138,19 @@ $template->param( > locations_loop=>$locations_loop, > ); > >-$template->param( additional_fields_for_subscription => [ Koha::AdditionalFields->search( { tablename => 'subscription' } ) ] ); >+my @additional_fields = Koha::AdditionalFields->search({ tablename => 'subscription' }); >+my %additional_field_values; >+if ($subscriptionid) { >+ my $subscription = Koha::Subscriptions->find($subscriptionid); >+ foreach my $value ($subscription->additional_field_values) { >+ $additional_field_values{$value->field_id} = $value->value; >+ } >+} >+ >+$template->param( >+ additional_fields => \@additional_fields, >+ additional_field_values => \%additional_field_values, >+); > > my $typeloop = { map { $_->{itemtype} => $_ } @{ Koha::ItemTypes->search_with_localization->unblessed } }; > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15774
:
48224
|
53608
|
53609
|
72078
|
72079
|
72085
|
72086
|
75083
|
75084
|
75085
|
75086
|
75336
|
75354
|
75361
|
79976
|
79977
|
79978
|
79979
|
79980
|
79981
|
79982
|
80060
|
80061
|
80062
|
80063
|
80064
|
80065
|
80066
|
80680
|
81490
|
81491
|
81492
|
81493
|
81494
|
81495
|
81496
|
81497
|
81833
|
81837
|
81838
|
81839
|
81840
|
81841
|
81842
|
81843
|
81844
|
81845
|
81846
|
81847
|
81848
|
81849
|
81850
|
81851
|
81852
|
83349
|
83350
|
83351
|
83352
|
83353
|
83354
|
83355
|
83356
|
83357
|
83358
|
83359
|
83360
|
83361
|
83362
|
83363
|
83364
|
83444
|
83445
|
83446
|
83447
|
83448
|
83449
|
83450
|
83451
|
83452
|
83453
|
83454
|
83455
|
83456
|
83457
|
83458
|
83459
|
85333
|
85334
|
85335
|
85336
|
85337
|
85338
|
85339
|
85340
|
85341
|
85342
|
85343
|
85344
|
85345
|
85346
|
85347
|
85348
|
85792
|
85806
|
85807
|
85808
|
85809
|
85810
|
85811
|
85812
|
85813
|
85814
|
85815
|
85816
|
85817
|
85818
|
85819
|
85820
|
85821
|
85822
|
85823
|
85824
|
86411