Bugzilla – Attachment 81537 Details for
Bug 21596
Handle default values when storing Koha::Patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21596: (follow-up 2) Handle updated_on
Bug-21596-follow-up-2-Handle-updatedon.patch (text/plain), 1.20 KB, created by
Jonathan Druart
on 2018-10-29 20:29:40 UTC
(
hide
)
Description:
Bug 21596: (follow-up 2) Handle updated_on
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-10-29 20:29:40 UTC
Size:
1.20 KB
patch
obsolete
>From 71825a127dca8d372291f31d1d76fc71ce99564d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 29 Oct 2018 17:27:52 -0300 >Subject: [PATCH] Bug 21596: (follow-up 2) Handle updated_on > >It seems that I have over complicated things here, now >t/db_dependent/Koha/Object.t is failing > >Apparently everything is ok with this change. >Test plan: >prove -r prove -r t/db_dependent/Koha/Object.t t/Auth_with_shibboleth.t >t/db_dependent/Patrons.t t/db_dependent/Koha/Patron* > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > Koha/Patron.pm | 4 ---- > 1 file changed, 4 deletions(-) > >diff --git a/Koha/Patron.pm b/Koha/Patron.pm >index c3ea18ff06..5831034bdc 100644 >--- a/Koha/Patron.pm >+++ b/Koha/Patron.pm >@@ -200,10 +200,6 @@ sub store { > > if ( defined $self->updated_on and not $self->updated_on ) { > $self->updated_on(undef); >- } elsif ( not $self->updated_on ) { >- # This is bad we should use columns_info instead >- # But it will avoid unecessary processing >- $self->updated_on(\"current_timestamp"); > } > > # Set default values if not set >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21596
:
80804
|
80807
|
80808
|
80809
|
80810
|
80837
|
80838
|
80839
|
80840
|
80844
|
80845
|
80846
|
80847
|
81080
|
81160
| 81537