Attachment 81631 Details for Bug 15836 – Bug 15836: Mark C4::ClassSource subs DEPRECATED

[patch] Bug 15836: Mark C4::ClassSource subs DEPRECATED

Bug-15836-Mark-C4ClassSource-subs-DEPRECATED.patch (text/plain), 2.63 KB, created by Jonathan Druart on 2018-10-30 15:56:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-10-30 15:56:15 UTC

Size: 2.63 KB

patch

obsolete

>From 629cb05a35523364ee6d0ed776e644f71fba0e75 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 22 Jun 2018 12:21:01 -0300
>Subject: [PATCH] Bug 15836: Mark C4::ClassSource subs DEPRECATED
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>These subs are no longer used from scripts and should be removed. It
>should be done on a separate bug report given that additional work is
>needed
>
>Sponsored-by: Goethe-Institut
>
>Signed-off-by: Christian StelzenmÃ¼ller <christian.stelzenmueller@bsz-bw.de>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>---
> C4/ClassSource.pm     | 20 +++++++++++++-------
> admin/classsources.pl |  1 -
> 2 files changed, 13 insertions(+), 8 deletions(-)
>
>diff --git a/C4/ClassSource.pm b/C4/ClassSource.pm
>index 245f9589c6..fc4cfbb658 100644
>--- a/C4/ClassSource.pm
>+++ b/C4/ClassSource.pm
>@@ -48,16 +48,10 @@ sources and sorting rules.
> @ISA    = qw(Exporter);
> @EXPORT = qw(
>     &GetClassSources
>-    &AddClassSource
>     &GetClassSource
>-    &ModClassSource
>-    &DelClassSource
>     &GetClassSortRules
>-    &AddClassSortRule
>     &GetClassSortRule
>-    &ModClassSortRule
>-    &DelClassSortRule
>-  
>+
>     &GetSourcesForSortRule
>     &GetClassSort
>     
>@@ -103,6 +97,8 @@ sub GetClassSources {
> 
> =head2 AddClassSource
> 
>+  DEPRECATED
>+
>   AddClassSource($cn_source, $description, $used, $class_sort_rule);
> 
>   Adds a class_sources row.
>@@ -144,6 +140,8 @@ sub GetClassSource {
> 
> =head2 ModClassSource 
> 
>+  DEPRECATED
>+
>   ModClassSource($cn_source, $description, $used, $class_sort_rule);
> 
>   Updates a class_sources row.
>@@ -165,6 +163,8 @@ sub ModClassSource {
> 
> =head2 DelClassSource 
> 
>+  DEPRECATED
>+
>   DelClassSource($cn_source);
> 
>   Deletes class_sources row.
>@@ -219,6 +219,8 @@ sub GetClassSortRules {
> 
> =head2 AddClassSortRule
> 
>+  DEPRECATED
>+
>   AddClassSortRule($class_sort_rule, $description, $sort_routine);
> 
>   Adds a class_sort_rules row.
>@@ -260,6 +262,8 @@ sub GetClassSortRule {
> 
> =head2 ModClassSortRule 
> 
>+  DEPRECATED
>+
>   ModClassSortRule($class_sort_rule, $description, $sort_routine);
> 
>   Updates a class_sort_rules row.
>@@ -280,6 +284,8 @@ sub ModClassSortRule {
> 
> =head2 DelClassSortRule 
> 
>+  DEPRECATED
>+
>   DelClassSortRule($class_sort_rule);
> 
>   Deletes class_sort_rules row.
>diff --git a/admin/classsources.pl b/admin/classsources.pl
>index 14d86dac55..697db41e45 100755
>--- a/admin/classsources.pl
>+++ b/admin/classsources.pl
>@@ -25,7 +25,6 @@ use C4::Auth;
> use C4::Context;
> use C4::Output;
> use C4::Koha;
>-use C4::ClassSource;
> use C4::ClassSortRoutine;
> use C4::ClassSplitRoutine;
> use Koha::ClassSources;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 15836: 76691 | 76692 | 76693 | 76694 | 76695 | 76696 | 77061 | 77079 | 77306 | 78791 | 78793 | 78795 | 78796 | 78798 | 78799 | 79029 | 80339 | 80340 | 80341 | 80342 | 80343 | 80344 | 80345 | 80346 | 80347 | 80548 | 80549 | 80550 | 80551 | 80552 | 80553 | 80554 | 80555 | 80556 | 81033 | 81034 | 81035 | 81036 | 81037 | 81038 | 81039 | 81040 | 81041 | 81627 | 81628 | 81629 | 81630 | 81631 | 81632 | 81633 | 81634 | 81635 | 82110 | 82112 | 82113 | 82118 | 82119 | 82120 | 82289 | 82290 | 82291 | 82292 | 82293 | 82294 | 82295 | 82296 | 82297 | 82298 | 82299 | 82300 | 82301 | 82302 | 82317 | 82318 | 82319 | 82321