Bugzilla – Attachment 81686 Details for
Bug 21585
Missing firstnames should be gracefully ignored in ILL requests table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21585 - Ignore missing firstname in ILL requests table
Bug-21585---Ignore-missing-firstname-in-ILL-reques.patch (text/plain), 1.93 KB, created by
Andrew Isherwood
on 2018-10-31 09:27:25 UTC
(
hide
)
Description:
Bug 21585 - Ignore missing firstname in ILL requests table
Filename:
MIME Type:
Creator:
Andrew Isherwood
Created:
2018-10-31 09:27:25 UTC
Size:
1.93 KB
patch
obsolete
>From 61b4625e3fe2b5f2b5bc52273fdb56b41a97db6d Mon Sep 17 00:00:00 2001 >From: Magnus Enger <magnus@libriotech.no> >Date: Tue, 16 Oct 2018 21:25:43 +0200 >Subject: [PATCH] Bug 21585 - Ignore missing firstname in ILL requests table > >To test: >- Make sure you have a patron with just a surname and no firstname >- Create an ILL request so that the name of this patron shows up in > the Patron column of the ILL requests table >- Before the patch, the name will display as "null Surname" >- Apply the patch >- Reload the ILL requests page >- The name should now display as just "Surname" >- Sign ye merrily off > >Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >index bc6f40a936..d93a13622e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >@@ -110,11 +110,14 @@ > > // Our 'render' function for borrowerlink > var createPatronLink = function(data, type, row) { >- return '<a title="' + _("View borrower details") + '" ' + >+ var patronLink = '<a title="' + _("View borrower details") + '" ' + > 'href="/cgi-bin/koha/members/moremember.pl?' + >- 'borrowernumber='+row.borrowernumber+'">' + >- row.patron_firstname + ' ' + row.patron_surname + >- '</a>'; >+ 'borrowernumber='+row.borrowernumber+'">'; >+ if ( row.patron_firstname ) { >+ patronLink = patronLink + row.patron_firstname + ' '; >+ } >+ patronLink = patronLink + row.patron_surname + '</a>'; >+ return patronLink > }; > > // Our 'render' function for biblio_id >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21585
:
80679
|
81686
|
81723