Attachment 81704 Details for Bug 21732 – Bug 21732: (QA follow-up) Performance Improvement

[patch] Bug 21732: (QA follow-up) Performance Improvement

Bug-21732-QA-follow-up-Performance-Improvement.patch (text/plain), 1004 bytes, created by Martin Renvoize (ashimema) on 2018-10-31 11:11:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2018-10-31 11:11:18 UTC

Size: 1004 bytes

patch

obsolete

>From 140271daf22b2bb8498c5bcd4233310f2ef97b98 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 31 Oct 2018 10:43:28 +0000
>Subject: [PATCH] Bug 21732: (QA follow-up) Performance Improvement
>
>We don't really need to lookup transfers before deleting them here.
>---
> C4/Circulation.pm | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index f436a5e54d..221ed31a9f 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -3680,9 +3680,8 @@ sub LostItem{
>         MarkIssueReturned($borrowernumber,$itemnumber,undef,undef,$patron->privacy) if $mark_returned;
>     }
> 
>-    my $transfers = GetTransfers($itemnumber);
>-    if ( C4::Context->preference('LostItemCancelOutstandingTransfers') && $transfers ) {
>-         my $deletedtransfer = DeleteTransfer($itemnumber);
>+    if ( C4::Context->preference('LostItemCancelOutstandingTransfers') ) {
>+         DeleteTransfer($itemnumber);
>     }
> 
> }
>-- 
>2.19.1

Actions: View | Diff | Splinter Review

Attachments on bug 21732: 81695 | 81696 | 81701 | 81702 | 81703 | 81704 | 81782