Bugzilla – Attachment 81728 Details for
Bug 20312
Add a link towards the last consulted patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20312: (QA follow-up) Make display syspref driven
Bug-20312-QA-follow-up-Make-display-syspref-driven.patch (text/plain), 3.90 KB, created by
Martin Renvoize (ashimema)
on 2018-10-31 14:22:47 UTC
(
hide
)
Description:
Bug 20312: (QA follow-up) Make display syspref driven
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2018-10-31 14:22:47 UTC
Size:
3.90 KB
patch
obsolete
>From 36f0db9d259acbfa249f62c78bf869da66c78d14 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 31 Oct 2018 13:53:16 +0000 >Subject: [PATCH] Bug 20312: (QA follow-up) Make display syspref driven > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > installer/data/mysql/atomicupdate/bug_20312.perl | 12 ++++++++++++ > installer/data/mysql/sysprefs.sql | 1 + > koha-tmpl/intranet-tmpl/prog/en/includes/header.inc | 2 +- > .../en/modules/admin/preferences/staff_client.pref | 6 ++++++ > 4 files changed, 20 insertions(+), 1 deletion(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_20312.perl > >diff --git a/installer/data/mysql/atomicupdate/bug_20312.perl b/installer/data/mysql/atomicupdate/bug_20312.perl >new file mode 100644 >index 0000000000..579a839483 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_20312.perl >@@ -0,0 +1,12 @@ >+$DBversion = 'XXX'; # will be replaced by the RM >+if( CheckVersion( $DBversion ) ) { >+ # System preferences >+ $dbh->do(q{ >+ INSERT IGNORE INTO `systempreferences` (`variable`,`value`,`explanation`,`options`,`type`) >+ VALUES ('showLastPatron','0','','If ON, enables the last patron feature in the intranet','YesNo'); >+ }); >+ >+ # Always end with this (adjust the bug info) >+ SetVersion( $DBversion ); >+ print "Upgrade to $DBversion done (Bug 20312 - Add showLastPatron systempreference)\n"; >+} >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 0f86627024..5fcb5ade4e 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -512,6 +512,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('ShelfBrowserUsesHomeBranch','1','1','Use the item home branch when finding items for the shelf browser.','YesNo'), > ('ShelfBrowserUsesLocation','1','1','Use the item location when finding items for the shelf browser.','YesNo'), > ('ShowAllCheckins', '0', '', 'Show all checkins', 'YesNo'), >+('showLastPatron','0','','If ON, enables the last patron feature in the intranet','YesNo'), > ('ShowPatronImageInWebBasedSelfCheck','0','','If ON, displays patron image when a patron uses web-based self-checkout','YesNo'), > ('ShowReviewer','full','none|full|first|surname|firstandinitial|username','Choose how a commenter\'s identity is presented alongside comments in the OPAC','Choice'), > ('ShowReviewerPhoto','1','','If ON, photo of reviewer will be shown beside comments in OPAC','YesNo'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc >index 997fe50f09..a693da9abb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc >@@ -148,6 +148,6 @@ > [% END %] > </ul> > </div> >- [% INCLUDE 'last-borrower.inc' %] >+ [% IF Koha.Preference('showLastPatron') %][% INCLUDE 'last-borrower.inc' %][% END %] > [% IF ( intranetbookbag ) %]<div id="cartDetails">Your cart is empty.</div>[% END %] > </div> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref >index 1822c7ab24..512785360c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref >@@ -137,6 +137,12 @@ Staff Client: > no: Show > yes: "Don't show" > - the names of patrons that have items checked out or on hold on detail pages or the "Place Hold" screen. >+ - >+ - pref: showLastPatron >+ choices: >+ no: "Don't show" >+ yes: Show >+ - a link to the last searched patron in the staff client. > - > - pref: intranetbookbag > choices: >-- >2.19.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20312
:
72294
|
72638
|
75672
|
77272
|
77769
|
77796
|
77835
|
77977
|
77979
|
78002
|
78005
|
81726
|
81727
| 81728