Attachment 81765 Details for Bug 21706 – Bug 21706: Make authority framework subfield links work (TT filter)

[patch] Bug 21706: Make authority framework subfield links work (TT filter)

Bug-21706-Make-authority-framework-subfield-links-.patch (text/plain), 2.73 KB, created by Jonathan Druart on 2018-10-31 17:56:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-10-31 17:56:30 UTC

Size: 2.73 KB

patch

obsolete

>From 086cd2a1d000d449eefcf956b63cca2ebc513fc2 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 29 Oct 2018 10:44:46 -0300
>Subject: [PATCH] Bug 21706: Make authority framework subfield links work (TT
> filter)
>
>This patch removes URL building from the controller
>and does it on the templates, using the
>right 'uri' filter for the query parameters.
>
>To test:
>- Go to Home > Administration > Athority types
>- On any of the listed frameworks, pick the 'MARC structure' action in
>the dropdown
>- On any subfield, hover on the actions dropdown
>=> FAIL: The URLs are wrongly formed
>- Click on the links
>=> FAIL: You get errors because of the bad URL
>- Apply this patch
>- Reload the 'MARC structure' page
>- On any subfield, hover on the actions dropdown
>=> SUCCESS: LInks look correct
>- Click on any of them
>=> SUCCESS: They work!
>- Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt
>index cb57caf085..25872c65cf 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt
>@@ -213,9 +213,9 @@
> <a class="btn btn-default btn-xs dropdown-toggle" id="authtagactions[% loo.tagfield | html %]" role="button" data-toggle="dropdown" href="#">
> Actions </a>
> <ul class="dropdown-menu pull-right" role="menu" aria-labelledby="authtagactions[% loo.tagfield | html %]">
>- <li><a href="[% loo.subfield_link | uri %]"> Subfields</a></li>
>- <li><a href="[% loo.edit | uri %]"> Edit</a></li>
>- <li><a href="[% loo.delete | uri %]"> Delete</a></li>
>+ <li><a href="auth_subfields_structure.pl?tagfield=[% loo.tagfield | uri %]&amp;authtypecode=[% authtypecode | uri %]"> Subfields</a></li>
>+ <li><a href="?op=add_form&amp;searchfield=[% loo.tagfield | uri %]&amp;authtypecode=[% authtypecode | uri %]"> Edit</a></li>
>+ <li><a href="?op=delete_confirm&amp;searchfield=[% loo.tagfield | uri %]&amp;authtypecode=[% authtypecode | uri %]"> Delete</a></li>
> </ul>
> </div>
> </td>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21706: 81500 | 81501 | 81506 | 81729 | 81765 | 81766 | 81767 | 81768 | 82004 | 82005 | 82006 | 82007 | 82245 | 82246 | 82247 | 82248