Attachment 81766 Details for Bug 21706 – Bug 21706: (follow-up) remove unused template params

[patch] Bug 21706: (follow-up) remove unused template params

Bug-21706-follow-up-remove-unused-template-params.patch (text/plain), 2.58 KB, created by Jonathan Druart on 2018-10-31 17:56:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-10-31 17:56:34 UTC

Size: 2.58 KB

patch

obsolete

>From 7fb53654ef50c76765c807bdf6bb4b855b12e94a Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 29 Oct 2018 10:51:39 -0300
>Subject: [PATCH] Bug 21706: (follow-up) remove unused template params
>
>The original patch removed the need to add URLs to the template
>variables. This patch removes that in the controller.
>
>Bonus: fixes 'html' filter in URL replacing it by 'uri'.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> admin/auth_tag_structure.pl                                         | 3 ---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt | 2 +-
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/admin/auth_tag_structure.pl b/admin/auth_tag_structure.pl
>index 121e04f17d..3912da7fac 100755
>--- a/admin/auth_tag_structure.pl
>+++ b/admin/auth_tag_structure.pl
>@@ -197,9 +197,6 @@ if ($op eq 'add_form') {
>         $row_data{repeatable}       = $results->[$i]{'repeatable'};
>         $row_data{mandatory}        = $results->[$i]{'mandatory'};
>         $row_data{authorised_value} = $results->[$i]{'authorised_value'};
>-        $row_data{subfield_link}    = "auth_subfields_structure.pl?tagfield=" . $results->[$i]{'tagfield'} . "&amp;authtypecode=" . $authtypecode;
>-        $row_data{edit}             = "$script_name?op=add_form&amp;searchfield=" . $results->[$i]{'tagfield'} . "&amp;authtypecode=" . $authtypecode;
>-        $row_data{delete}           = "$script_name?op=delete_confirm&amp;searchfield=" . $results->[$i]{'tagfield'} . "&amp;authtypecode=" . $authtypecode;
>         push(@loop_data, \%row_data);
>     }
>     $template->param(loop => \@loop_data,
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt
>index 25872c65cf..76f75d5a12 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt
>@@ -170,7 +170,7 @@
> [% IF ( else ) %]
> 
> <div id="toolbar" class="btn-toolbar">
>-    <div class="btn-group"><a class="btn btn-default btn-sm" id="newtag" href="/cgi-bin/koha/admin/auth_tag_structure.pl?op=add_form&amp;authtypecode=[% authtypecode | html %]"><i class="fa fa-plus"></i> New tag</a></div>
>+    <div class="btn-group"><a class="btn btn-default btn-sm" id="newtag" href="/cgi-bin/koha/admin/auth_tag_structure.pl?op=add_form&amp;authtypecode=[% authtypecode | uri %]"><i class="fa fa-plus"></i> New tag</a></div>
> </div>
> 
> <h2>Select an authority framework</h2>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21706: 81500 | 81501 | 81506 | 81729 | 81765 | 81766 | 81767 | 81768 | 82004 | 82005 | 82006 | 82007 | 82245 | 82246 | 82247 | 82248