Attachment 81779 Details for Bug 21742 – Bug 21742: Fix YouTube variable propagation

[patch] Bug 21742: Fix YouTube variable propagation

Bug-21742-Fix-YouTube-variable-propagation.patch (text/plain), 1.61 KB, created by Jonathan Druart on 2018-10-31 20:20:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-10-31 20:20:37 UTC

Size: 1.61 KB

patch

obsolete

>From c3d47de6c7d963a5647a881fb20356577aee0ab5 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 31 Oct 2018 12:18:58 +0000
>Subject: [PATCH] Bug 21742: Fix YouTube variable propagation
>
>The loop to find all media has an $isyoutube variable. This was declared
>outside the loop and never reset. Once a YouTube video was encountered
>all subsequent videos were considered as YouTube. This patch reduces the
>scope of the variable and resets per loop.
>
>To test:
>1 - Enable HTML5Media and HTML5MediaYouTube
>2 - Add 856$u to record for a youtube vido and a pdf (sample record
>        attached to bug)
>3 - View the record, the Play media tab has two video boxes
>4 - Play the second, it fails
>5 - Apply patch
>6 - View record, Play media should include only one video link
>
>Signed-off-by: Devinim <kohadevinim@devinim.com.tr>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> C4/HTML5Media.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/HTML5Media.pm b/C4/HTML5Media.pm
>index 1ac22f17c3..c77e8a40bc 100644
>--- a/C4/HTML5Media.pm
>+++ b/C4/HTML5Media.pm
>@@ -50,8 +50,8 @@ sub gethtml5media {
>     my @HTML5MediaExtensions = split( /\|/, C4::Context->preference("HTML5MediaExtensions") );
>     my $HTML5MediaYouTube    = C4::Context->preference("HTML5MediaYouTube");
>     my $marcflavour          = C4::Context->preference("marcflavour");
>-    my $isyoutube            = 0;
>     foreach my $HTML5Media_field (@HTML5Media_fields) {
>+    my $isyoutube            = 0;
>         my %HTML5Media;
>         # protocol
>         if ( $HTML5Media_field->indicator(1) eq '1' ) {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21742: 81779