Bugzilla – Attachment 81812 Details for
Bug 21725
Incorrect HAVING in group by in Acquisitions.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21725: Use full statement in HAVING rather than constructed column
Bug-21725-Use-full-statement-in-HAVING-rather-than.patch (text/plain), 1.56 KB, created by
Jonathan Druart
on 2018-11-01 14:26:25 UTC
(
hide
)
Description:
Bug 21725: Use full statement in HAVING rather than constructed column
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-11-01 14:26:25 UTC
Size:
1.56 KB
patch
obsolete
>From 72a6b9cb8c147fa571a975956c16841f21f6e7b1 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 30 Oct 2018 11:59:26 +0000 >Subject: [PATCH] Bug 21725: Use full statement in HAVING rather than > constructed column > >To test: >1 - prove -v t/db_dpendent/Acquisition/GetBasketsInfosByBookseller.t >2 - Apply patch >3 - prove -v t/db_dpendent/Acquisition/GetBasketsInfosByBookseller.t >4 - It passes >5 - Have some open/closed and some fully and not full received baskets >6 - View a vendor and confirm baskets are shwn as expected >7 - Check 'Show all baskets' shows all baskets > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Note sure this is the best thing but it fixes the issue >--- > C4/Acquisition.pm | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index 8039afac61..0cca6fe832 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -713,7 +713,13 @@ sub GetBasketsInfosByBookseller { > > unless ( $allbaskets ) { > # Don't show the basket if it's NOT CLOSED or is FULLY RECEIVED >- $query.=" HAVING (closedate IS NULL OR (expected_items > 0))" >+ $query.=" HAVING (closedate IS NULL OR ( >+ SUM( >+ IF(aqorders.datereceived IS NULL >+ AND (aqorders.datecancellationprinted IS NULL OR aqorders.datecancellationprinted='0000-00-00') >+ , aqorders.quantity >+ , 0) >+ ) > 0))" > } > > my $sth = $dbh->prepare($query); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21725
:
81616
|
81626
| 81812