Bugzilla – Attachment 81869 Details for
Bug 21656
Syntax Error in Stock Rotation Default Notice Template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21656: (follow-up) Fix atomicupdate
Bug-21656-follow-up-Fix-atomicupdate.patch (text/plain), 2.21 KB, created by
Marcel de Rooy
on 2018-11-02 08:43:54 UTC
(
hide
)
Description:
Bug 21656: (follow-up) Fix atomicupdate
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-11-02 08:43:54 UTC
Size:
2.21 KB
patch
obsolete
>From 4ba7ee724af57717fd27ca09012c08370813bd70 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 25 Oct 2018 15:30:10 +0000 >Subject: [PATCH] Bug 21656: (follow-up) Fix atomicupdate >Content-Type: text/plain; charset=utf-8 > >The atomicupdate is going to run as part of an upgrade. >It needs to UPDATE, not INSERT. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > installer/data/mysql/atomicupdate/bug_21656.perl | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_21656.perl b/installer/data/mysql/atomicupdate/bug_21656.perl >index d0caab3..1b72856 100644 >--- a/installer/data/mysql/atomicupdate/bug_21656.perl >+++ b/installer/data/mysql/atomicupdate/bug_21656.perl >@@ -1,10 +1,8 @@ > $DBversion = 'XXX'; # will be replaced by the RM > if( CheckVersion( $DBversion ) ) { > $dbh->do(q{ >- INSERT IGNORE INTO `letter` (`module`, `code`, `branchcode`, `name`, `is_html`, `title`, `content`, `message_transport_type`) >- VALUES ('circulation', 'SR_SLIP', '', 'Stock Rotation Slip', 0, 'Stockrotation Report', 'Stockrotation report for [% branch.name %]:\r\n\r\n[% IF branch.items.size %][% branch.items.size %] items to be processed for this branch.\r\n[% ELSE %]No items to be processed for this branch\r\n[% END %][% FOREACH item IN branch.items %][% IF item.reason != \'in-demand\' %]Title: [% item.title %]\r\nAuthor: [% item.author %]\r\nCallnumber: [% item.callnumber %]\r\nLocation: [% item.location %]\r\nBarcode: [% item.barcode %]\r\nOn loan?: [% item.onloan %]\r\nStatus: [% item.reason %]\r\nCurrent Library: [% item.branch.branchname %] [% item.branch.branchcode %]\r\n\r\n[% END %][% END %]', 'email'); >+ UPDATE letter SET content = REPLACE(content,"item.reason ne \'in-demand\'","item.reason != \'in-demand\'"); > }); >- >- print "Upgrade to $DBversion done (Bug 21620 - Stock Rotation Notice, Template Toolkit Syntax Correction)\n"; >+ print "Upgrade to $DBversion done (Bug 21656 - Stock Rotation Notice, Template Toolkit Syntax Correction)\n"; > SetVersion( $DBversion ); > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21656
:
81109
|
81181
|
81185
|
81186
|
81187
|
81188
|
81275
|
81276
|
81277
|
81278
|
81868
| 81869 |
81870
|
81871