Bugzilla – Attachment 81877 Details for
Bug 21753
issuingrules.chargename is unused and should be removed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21753: DBRev to remove the field from the database
Bug-21753-DBRev-to-remove-the-field-from-the-datab.patch (text/plain), 2.00 KB, created by
Martin Renvoize (ashimema)
on 2018-11-02 10:42:09 UTC
(
hide
)
Description:
Bug 21753: DBRev to remove the field from the database
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2018-11-02 10:42:09 UTC
Size:
2.00 KB
patch
obsolete
>From 43abf7d3750f97f33615a7570073fc6cbf966b4c Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 2 Nov 2018 10:04:46 +0000 >Subject: [PATCH] Bug 21753: DBRev to remove the field from the database > >--- > installer/data/mysql/atomicupdate/bug_21753.perl | 10 ++++++++++ > installer/data/mysql/kohastructure.sql | 1 - > 2 files changed, 10 insertions(+), 1 deletion(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_21753.perl > >diff --git a/installer/data/mysql/atomicupdate/bug_21753.perl b/installer/data/mysql/atomicupdate/bug_21753.perl >new file mode 100644 >index 0000000000..f5e5d442f1 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_21753.perl >@@ -0,0 +1,10 @@ >+$DBversion = 'XXX'; # will be replaced by the RM >+if( CheckVersion( $DBversion ) ) { >+ if( column_exists( 'issuingrules', 'chargename' ) ) { >+ $dbh->do( "ALTER TABLE issuingrules DROP chargename" ); >+ } >+ >+ # Always end with this (adjust the bug info) >+ SetVersion( $DBversion ); >+ print "Upgrade to $DBversion done (Bug 21753: Drop chargename from issuingrules )\n"; >+} >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 629bc93569..09cfb9050d 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -855,7 +855,6 @@ CREATE TABLE `issuingrules` ( -- circulation and fine rules > `chargeperiod` int(11) default NULL, -- how often the fine amount is charged > `chargeperiod_charge_at` tinyint(1) NOT NULL DEFAULT '0', -- Should fine be given at the start ( 1 ) or the end ( 0 ) of the period > `accountsent` int(11) default NULL, -- not used? always NULL >- `chargename` varchar(100) default NULL, -- not used? always NULL > `maxissueqty` int(4) default NULL, -- total number of checkouts allowed > `maxonsiteissueqty` int(4) default NULL, -- total number of on-site checkouts allowed > `issuelength` int(4) default NULL, -- length of checkout in the unit set in issuingrules.lengthunit >-- >2.19.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21753
:
81876
|
81877
|
82715
|
82716
|
82730
|
82731
|
82732