Attachment 81996 Details for Bug 20996 – Bug 20996: (RM follow-up) Fix the api tests

[patch] Bug 20996: (RM follow-up) Fix the api tests

Bug-20996-RM-follow-up-Fix-the-api-tests.patch (text/plain), 3.12 KB, created by Martin Renvoize (ashimema) on 2018-11-06 16:43:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2018-11-06 16:43:03 UTC

Size: 3.12 KB

patch

obsolete

>From 75ce2bd1e4c4fcd4a26dd80ac96fcb356a6b2a9e Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 6 Nov 2018 16:36:03 +0000
>Subject: [PATCH] Bug 20996: (RM follow-up) Fix the api tests
>
>https://bugs.koha-community.org/show_bug.cgi?id=21766
>---
> t/db_dependent/api/v1/illrequests.t | 36 +++++++++++++++++++++--------
> 1 file changed, 27 insertions(+), 9 deletions(-)
>
>diff --git a/t/db_dependent/api/v1/illrequests.t b/t/db_dependent/api/v1/illrequests.t
>index b58d529c08..ec471830fb 100644
>--- a/t/db_dependent/api/v1/illrequests.t
>+++ b/t/db_dependent/api/v1/illrequests.t
>@@ -19,6 +19,7 @@ use Modern::Perl;
> 
> use Test::More tests => 1;
> use Test::MockModule;
>+use Test::MockObject;
> use Test::Mojo;
> use Test::Warn;
> 
>@@ -40,11 +41,27 @@ subtest 'list() tests' => sub {
> 
>     plan tests => 18;
> 
>+    # Mock ILLBackend (as object)
>+    my $backend = Test::MockObject->new;
>+    $backend->set_isa('Koha::Illbackends::Mock');
>+    $backend->set_always('name', 'Mock');
>+    $backend->set_always('capabilities', sub { return 'bar'; } );
>+    $backend->mock(
>+        'metadata',
>+        sub {
>+            my ( $self, $rq ) = @_;
>+            return {
>+                ID => $rq->illrequest_id,
>+                Title => $rq->patron->borrowernumber
>+            }
>+        }
>+    );
>+
>+    # Mock Koha::Illrequest::load_backend (to load Mocked Backend)
>     my $illreqmodule = Test::MockModule->new('Koha::Illrequest');
>-    # Mock ->capabilities
>-    $illreqmodule->mock( 'capabilities', sub { return 'capable'; } );
>-    # Mock ->metadata
>-    $illreqmodule->mock( 'metadata', sub { return 'metawhat?'; } );
>+    $illreqmodule->mock( 'load_backend',
>+        sub { my $self = shift; $self->{_my_backend} = $backend; return $self }
>+    );
> 
>     $schema->storage->txn_begin;
> 
>@@ -67,7 +84,7 @@ subtest 'list() tests' => sub {
>         {
>             class => 'Koha::Illrequests',
>             value => {
>-                backend        => 'FreeForm',
>+                backend        => 'Mock',
>                 branchcode     => $library->branchcode,
>                 borrowernumber => $patron->borrowernumber
>             }
>@@ -86,16 +103,17 @@ subtest 'list() tests' => sub {
>     $tx->req->cookies( { name => 'CGISESSID', value => $session_id } );
>     $tx->req->env( { REMOTE_ADDR => $remote_address } );
>     $t->request_ok($tx)->status_is(200)
>-        ->json_has( '/0/patron', $patron->unblessed )
>-        ->json_has( '/0/capabilities', 'capable' )
>-        ->json_has( '/0/library', $library->unblessed  )
>-        ->json_has( '/0/metadata', 'metawhat?'  );
>+        ->json_has( '/0/patron', 'patron embedded' )
>+        ->json_has( '/0/capabilities', 'capabilities embedded' )
>+        ->json_has( '/0/library', 'library embedded'  )
>+        ->json_has( '/0/metadata', 'metadata embedded'  );
> 
>     # Create another ILL request
>     my $illrequest2 = $builder->build_object(
>         {
>             class => 'Koha::Illrequests',
>             value => {
>+                backend        => 'Mock',
>                 branchcode     => $library->branchcode,
>                 borrowernumber => $patron->borrowernumber
>             }
>-- 
>2.19.1

Actions: View | Diff | Splinter Review

Attachments on bug 20996: 76687 | 76688 | 76705 | 77100 | 79379 | 79576 | 79583 | 79584 | 79585 | 79586 | 79587 | 79588 | 79589 | 79590 | 79591 | 79592 | 81715 | 81716 | 81717 | 81718 | 81719 | 81720 | 81747 | 81748 | 81749 | 81750 | 81751 | 81752 | 81753 | 81755 | 81756 | 81757 | 81758 | 81759 | 81760 | 81761 | 81908 | 81909 | 81928 | 81967 | 81994 | 81996 | 81997 | 81998