Bugzilla – Attachment 82007 Details for
Bug 21706
Editing subfields in authority frameworks is broken (TT filter)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21706: (QA follow-up) Fix tabs
Bug-21706-QA-follow-up-Fix-tabs.patch (text/plain), 2.80 KB, created by
Josef Moravec
on 2018-11-06 20:12:35 UTC
(
hide
)
Description:
Bug 21706: (QA follow-up) Fix tabs
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2018-11-06 20:12:35 UTC
Size:
2.80 KB
patch
obsolete
>From e7f18d6cc5e68182293541aa52fe364302530cac Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 31 Oct 2018 11:25:40 -0300 >Subject: [PATCH] Bug 21706: (QA follow-up) Fix tabs > >Not all href's should have parameters URI encoded. Because sometimes >they are just where for use by JavaScript libraries which fail in that >situations. For fixed-lenght fields we use @ as the subfield code and it >breaks the bootstrap tabs if we URI encode the '@'. > >This fixes the tabs issues on fixed-lenght fields in the authority type >editing pages. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > .../intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >index e09a45a..b5da79e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >@@ -40,14 +40,14 @@ > <input type="hidden" name="op" value="add_validate" /> > <input type="hidden" name="tagfield" value="[% tagfield | html %]" /> > <input type="hidden" name="authtypecode" value="[% authtypecode | html %]" /> >- <fieldset class="action"><input type="submit" class="submit" value="Save changes" /> <a class="cancel" href="/cgi-bin/koha/admin/auth_subfields_structure.pl?tagfield=[% tagfield | uri %]&authtypecode=[% authtypecode |uri %]">Cancel</a></fieldset> >+ <fieldset class="action"><input type="submit" class="submit" value="Save changes" /> <a class="cancel" href="/cgi-bin/koha/admin/auth_subfields_structure.pl?tagfield=[% tagfield | uri %]&authtypecode=[% authtypecode | uri %]">Cancel</a></fieldset> > <div id="subfieldtabs" class="toptabs numbered"> > <ul> > [% FOREACH loo IN loop %] > [% IF ( loo.new_subfield ) %] >- <li><a href="#sub[% loo.tagsubfield | uri %]field" title="[% loo.liblibrarian | html_entity %]">New</a></li> >+ <li><a href="#sub[% loo.tagsubfield | html_entity %]field" title="[% loo.liblibrarian | html_entity %]">New</a></li> > [% ELSE %] >- <li><a href="#sub[% loo.tagsubfield | uri %]field" title="[% loo.liblibrarian | html_entity %]"> >+ <li><a href="#sub[% loo.tagsubfield | html_entity %]field" title="[% loo.liblibrarian | html_entity %]"> > [% loo.tagsubfield | html %] > </a></li> > [% END %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21706
:
81500
|
81501
|
81506
|
81729
|
81765
|
81766
|
81767
|
81768
|
82004
|
82005
|
82006
|
82007
|
82245
|
82246
|
82247
|
82248