Bugzilla – Attachment 82021 Details for
Bug 21777
Checkouts table in circulation is out of alignment
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21777: Fix circulation table alignment
Bug-21777-Fix-circulation-table-alignment.patch (text/plain), 3.56 KB, created by
Nick Clemens (kidclamp)
on 2018-11-07 12:20:14 UTC
(
hide
)
Description:
Bug 21777: Fix circulation table alignment
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2018-11-07 12:20:14 UTC
Size:
3.56 KB
patch
obsolete
>From 309c9443d28d4d7ced2c5881f5fd7a0901d8f3f6 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 7 Nov 2018 12:16:08 +0000 >Subject: [PATCH] Bug 21777: Fix circulation table alignment > >TO test: >1 - Check out an item to a patron >2 - Note the columns are misaligned >3 - Apply patch >4 - Updatedatabase >5 - Reload the patron >6 - Note the table is fixed >--- > admin/columns_settings.yml | 5 +++++ > .../Bug_21777_Hide_column_for_sorting_checkout_on.perl | 9 +++++++++ > .../intranet-tmpl/prog/en/includes/checkouts-table-footer.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc | 1 + > 4 files changed, 16 insertions(+), 1 deletion(-) > create mode 100644 installer/data/mysql/atomicupdate/Bug_21777_Hide_column_for_sorting_checkout_on.perl > >diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml >index 14800190c3..cabd03ceb2 100644 >--- a/admin/columns_settings.yml >+++ b/admin/columns_settings.yml >@@ -494,6 +494,11 @@ modules: > - > columnname: homebranch > - >+ columnname: checkout_on_unformatted >+ cannot_be_toggled: 1 >+ cannot_be_modified: 1 >+ is_hidden: 1 >+ - > columnname: checkout_on > - > columnname: checkout_from >diff --git a/installer/data/mysql/atomicupdate/Bug_21777_Hide_column_for_sorting_checkout_on.perl b/installer/data/mysql/atomicupdate/Bug_21777_Hide_column_for_sorting_checkout_on.perl >new file mode 100644 >index 0000000000..0f19e8ca55 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/Bug_21777_Hide_column_for_sorting_checkout_on.perl >@@ -0,0 +1,9 @@ >+$DBversion = 'XXX'; # will be replaced by the RM >+if( CheckVersion( $DBversion ) ) { >+ $dbh->do( q{ >+ INSERT IGNORE INTO columns_settings (module, page, tablename, columnname, cannot_be_toggled, is_hidden) VALUES >+ ("circ", "circulation", "issues-table", "checkout_on_unformatted", 1, 1); >+ }); >+ SetVersion( $DBversion ); >+ print "Upgrade to $DBversion done (Bug 21777: Fix circulation table alignment)\n"; >+} >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table-footer.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table-footer.inc >index b831c1e507..d8f1abb438 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table-footer.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table-footer.inc >@@ -1,6 +1,6 @@ > <tfoot> > <tr> >- <td colspan="11" style="text-align: right; font-weight:bold;">Totals:</td> >+ <td colspan="12" style="text-align: right; font-weight:bold;">Totals:</td> > <td id="totaldue" style="text-align: right;">[% totaldue | html %]</td> > <td id="totalfine" style="text-align: right;">[% finetotal | html %]</td> > <td id="totalprice" style="text-align: right;">[% totalprice | html %]</td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc >index d78e001da0..7b4b622762 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc >@@ -19,6 +19,7 @@ > <th scope="col">Collection</th> > <th scope="col">Location</th> > <th scope="col">Home library</th> >+ <th scope="col"> </th> > <th scope="col">Checked out on</th> > <th scope="col">Checked out from</th> > <th scope="col">Call no</th> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21777
:
82021
|
82023
|
82043
|
82231
|
82287
|
82288
|
82320