Bugzilla – Attachment 82050 Details for
Bug 18316
Add weighting/relevancy options to ElasticSearch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18316: (follow-up) Don't let 'fields' be undef and adjust tests
Bug-18316-follow-up-Dont-let-fields-be-undef-and-a.patch (text/plain), 1.58 KB, created by
Nick Clemens (kidclamp)
on 2018-11-08 01:51:21 UTC
(
hide
)
Description:
Bug 18316: (follow-up) Don't let 'fields' be undef and adjust tests
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2018-11-08 01:51:21 UTC
Size:
1.58 KB
patch
obsolete
>From c8309b649eeb9a00a891752351f08624558aaa14 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 8 Nov 2018 01:50:34 +0000 >Subject: [PATCH] Bug 18316: (follow-up) Don't let 'fields' be undef and adjust > tests > >--- > Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 2 +- > t/db_dependent/www/search_utf8.t | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm >index fd98c36..57836e9 100644 >--- a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm >+++ b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm >@@ -92,7 +92,7 @@ sub build_query { > default_operator => 'AND', > default_field => '_all', > lenient => JSON::true, >- fields => $options{fields}, >+ fields => $options{fields} || [], > } > }; > >diff --git a/t/db_dependent/www/search_utf8.t b/t/db_dependent/www/search_utf8.t >index 3b3c22f..85a227a 100644 >--- a/t/db_dependent/www/search_utf8.t >+++ b/t/db_dependent/www/search_utf8.t >@@ -266,7 +266,7 @@ sub test_search{ > $intra_text = $agent->text(); > > like( $intra_text, qr|Publisher: $publisher|, ); >- my $expected_base = q|search.pl\?idx=kw&q=| . uri_escape_utf8( $publisher ); >+ my $expected_base = q|search.pl\?advsearch=1&idx=kw&q=| . uri_escape_utf8( $publisher ); > $agent->base_like(qr|$expected_base|, ); > > ok ( ( length(Encode::encode('UTF-8', $intra_text)) != length($intra_text) ) , 'UTF-8 are multi-byte. Good') ; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18316
:
61472
|
73139
|
73140
|
73492
|
73493
|
73600
|
73601
|
74112
|
74115
|
74116
|
74117
|
74714
|
74720
|
74751
|
74752
|
74753
|
74754
|
75073
|
75074
|
75075
|
75076
|
75458
|
75490
|
75519
|
75520
|
75521
|
75522
|
75523
|
75524
|
75525
|
75526
|
75527
|
75528
|
75529
|
75530
|
75531
|
75536
|
75537
|
75538
|
75539
|
75540
|
75541
|
75699
|
75730
|
77661
|
77662
|
77663
|
77664
|
77665
|
77666
|
77667
|
78396
|
78397
|
78398
|
78399
|
78400
|
78401
|
78402
|
78403
|
80278
|
80335
|
81004
|
81005
|
81006
|
81007
|
81008
|
81009
|
81010
|
81011
|
81012
|
81507
|
81508
|
81509
|
81510
|
81511
|
81512
|
81513
|
81514
|
81515
|
81516
| 82050