Attachment 82068 Details for Bug 20581 – Bug 20581: Unit tests for status_alias

[patch] Bug 20581: Unit tests for status_alias

Bug-20581-Unit-tests-for-statusalias.patch (text/plain), 2.71 KB, created by Andrew Isherwood on 2018-11-08 12:01:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Isherwood

Created: 2018-11-08 12:01:53 UTC

Size: 2.71 KB

patch

obsolete

>From 11ab80b25f26dac9260e26fa4c717089b0bbbedd Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Tue, 17 Apr 2018 17:00:32 +0100
>Subject: [PATCH] Bug 20581: Unit tests for status_alias
>
>This patch adds unit tests for the specific status_alias functionality
>added in this bug
>
>- Creation of the ILLSTATUS authorised value
>- Illrequest->statusalias accessor
>- Illrequest->status overloading to reset status_alias
>
>To test:
>1) Apply this patch
>2) prove t/db_dependent/Illrequests.t
>
>Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie
>---
> t/db_dependent/Illrequests.t | 57 +++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 56 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Illrequests.t b/t/db_dependent/Illrequests.t
>index a9f933acf6..fc20d2d0aa 100644
>--- a/t/db_dependent/Illrequests.t
>+++ b/t/db_dependent/Illrequests.t
>@@ -22,13 +22,15 @@ use Koha::Database;
> use Koha::Illrequestattributes;
> use Koha::Illrequest::Config;
> use Koha::Patrons;
>+use Koha::AuthorisedValueCategories;
>+use Koha::AuthorisedValues;
> use t::lib::Mocks;
> use t::lib::TestBuilder;
> use Test::MockObject;
> use Test::MockModule;
> use Test::Exception;
> 
>-use Test::More tests => 10;
>+use Test::More tests => 11;
> 
> my $schema = Koha::Database->new->schema;
> my $builder = t::lib::TestBuilder->new;
>@@ -795,3 +797,56 @@ subtest 'Checking Limits' => sub {
> 
>     $schema->storage->txn_rollback;
> };
>+
>+subtest 'Custom statuses' => sub {
>+
>+    plan tests => 3;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $cat = Koha::AuthorisedValueCategories->search(
>+        {
>+            category_name => 'ILLSTATUS'
>+        }
>+    );
>+
>+    if ($cat->count == 0) {
>+        $cat  = $builder->build_object(
>+            {
>+                class => 'Koha::AuthorisedValueCategory',
>+                value => {
>+                    category_name => 'ILLSTATUS'
>+                }
>+            }
>+        );
>+    };
>+
>+    my $av = $builder->build_object(
>+        {
>+            class => 'Koha::AuthorisedValues',
>+            value => {
>+                category => 'ILLSTATUS'
>+            }
>+        }
>+    );
>+
>+    is($av->category, 'ILLSTATUS',
>+       "Successfully created authorised value for custom status");
>+
>+    my $ill_req = $builder->build_object(
>+        {
>+            class => 'Koha::Illrequests',
>+            value => {
>+                status_alias => $av->id
>+            }
>+        }
>+    );
>+    isa_ok($ill_req->statusalias, 'Koha::AuthorisedValue',
>+           "statusalias correctly returning Koha::AuthorisedValue object");
>+
>+    $ill_req->status("COMP");
>+    is($ill_req->statusalias, undef,
>+        "Koha::Illrequest->status overloading resetting status_alias");
>+
>+    $schema->storage->txn_rollback;
>+};
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20581: 74323 | 74324 | 74325 | 74326 | 74327 | 74362 | 75333 | 75334 | 75810 | 77819 | 77820 | 77821 | 77822 | 77823 | 77824 | 77825 | 77826 | 78376 | 78377 | 78378 | 78379 | 78380 | 78381 | 78382 | 78383 | 78384 | 78431 | 78515 | 78516 | 78517 | 78518 | 78519 | 78520 | 78521 | 78522 | 78523 | 80279 | 80280 | 80281 | 80282 | 80283 | 80284 | 80285 | 80286 | 80474 | 80475 | 80501 | 80503 | 80505 | 80598 | 80599 | 80600 | 82063 | 82064 | 82065 | 82066 | 82067 | 82068 | 82069 | 82070 | 82071 | 82072 | 82073 | 82074 | 82075 | 82076 | 82443 | 82444 | 82445 | 82446 | 82447 | 82448 | 82449 | 82450 | 82451 | 82452 | 82453 | 82454 | 82455 | 82456 | 82457 | 82458 | 82459 | 82460 | 82461 | 82462 | 82463 | 82464 | 82465 | 82466 | 82467 | 82468 | 82472 | 82483 | 82484 | 82485 | 82486 | 82487 | 82488 | 82489 | 82490 | 82491 | 82492 | 82493 | 82494 | 82495 | 82496 | 82733 | 84202 | 84404 | 84768 | 84770 | 84771 | 84772 | 84773 | 84774 | 84775 | 84776 | 84777 | 84778 | 84779 | 84780 | 84781 | 84782 | 84783 | 84784 | 84785 | 84791 | 84814 | 84818 | 84819 | 84844 | 84911 | 84912 | 84913 | 84914 | 84915 | 84916 | 84917 | 84918 | 84919 | 84920 | 84921 | 84922 | 84923 | 84924 | 84925 | 84926 | 84927 | 84928 | 84929 | 84930 | 84931 | 84964 | 85075 | 85076 | 85077 | 85078 | 85079 | 85080 | 85081 | 85082 | 85083 | 85084 | 85085 | 85086 | 85087 | 85088 | 85089 | 85090 | 85091 | 85092 | 85093 | 85094 | 85095 | 85096