Attachment 82127 Details for Bug 21467 – Bug 21467: Fix default sort

[patch] Bug 21467: Fix default sort

Bug-21467-Fix-default-sort.patch (text/plain), 2.59 KB, created by Katrin Fischer on 2018-11-08 22:07:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2018-11-08 22:07:20 UTC

Size: 2.59 KB

patch

obsolete

>From 39710b7d6f515629ceb79e5002b0c9a64697850f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 12 Oct 2018 14:26:44 -0300
>Subject: [PATCH] Bug 21467: Fix default sort
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Sponsored-by: BULAC - http://www.bulac.fr/
>
>Signed-off-by: SÃ©verine QUEUNE <severine.queune@bulac.fr>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../intranet-tmpl/prog/en/modules/serials/subscription-detail.tt    | 6 +-----
> serials/subscription-detail.pl                                      | 2 +-
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
>index 5cbbb9bc39..4f4fe026e0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
>@@ -358,7 +358,6 @@
> 
>                 <thead>
>                     <tr>
>-                        <th class="NoVisible">Timestamp</th>
>                         <th>Invoice</th>
>                         <th>Basket</th>
>                         <th>Order number</th>
>@@ -380,7 +379,6 @@
>                     [% ELSE %]
>                         <tr data-tt-id="[% order.parent_ordernumber | html %]">
>                     [% END %]
>-                        <td>[% order.timestamp | html %]</td>
>                         <td>
>                         [% IF order.invoice %]
>                             [% IF CAN_user_acquisition %]
>@@ -472,9 +470,7 @@
> 
>                 'bPaginate': false,
>                 'bAutoWidth': false,
>-                'bSort': true,
>-                'aaSortingFixed': [[ 0, 'desc' ]],
>-                "bSortCellsTop": true
>+                'bSort': false,
>             }, columns_settings);
> 
>             $(table).treetable({
>diff --git a/serials/subscription-detail.pl b/serials/subscription-detail.pl
>index 1d109eb22d..9ea681b23a 100755
>--- a/serials/subscription-detail.pl
>+++ b/serials/subscription-detail.pl
>@@ -129,7 +129,7 @@ for my $field ( @$additional_fields ) {
> $template->param( additional_fields_for_subscription => $additional_fields );
> 
> # FIXME Do we want to hide canceled orders?
>-my $orders = Koha::Acquisition::Orders->search( { subscriptionid => $subscriptionid } );
>+my $orders = Koha::Acquisition::Orders->search( { subscriptionid => $subscriptionid }, { order_by => { -desc => 'parent_ordernumber' } } );
> 
> $template->param(
>     subscriptionid => $subscriptionid,
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21467: 79801 | 79802 | 79834 | 79835 | 79836 | 79837 | 79838 | 80546 | 80706 | 80707 | 80717 | 80718 | 80719 | 80720 | 80721 | 80722 | 80723 | 80724 | 81394 | 81395 | 81396 | 81397 | 81398 | 81399 | 81400 | 81430 | 81797 | 81798 | 81799 | 81800 | 81801 | 81802 | 81803 | 81804 | 81805 | 81806 | 81807 | 81808 | 81809 | 81810 | 81811 | 82117 | 82122 | 82123 | 82124 | 82125 | 82126 | 82127 | 82128 | 82129 | 82130 | 82131 | 82132