Attachment 82190 Details for Bug 21346 – Bug 21346: Remove double dialog

[patch] Bug 21346: Remove double dialog

Bug-21346-Remove-double-dialog.patch (text/plain), 1.27 KB, created by ByWater Sandboxes on 2018-11-09 17:30:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2018-11-09 17:30:07 UTC

Size: 1.27 KB

patch

obsolete

>From c728972c873cde73528b3dff28c1765cecfb11a4 Mon Sep 17 00:00:00 2001
>From: Christopher Brannon <cbrannon@cdalibrary.org>
>Date: Thu, 1 Nov 2018 21:08:19 +0000
>Subject: [PATCH] Bug 21346: Remove double dialog
>
>To Test:
>1) Place a hold on an item for pickup at another branch.
>2) Check in item to trigger hold and transfer.
>3) Check in item again without changing location.  Note modal AND old
>dialog behind modal.
>4) Apply patch.
>5) Check in item again without changing location.  Note modal without
>the old dialog.
>
>Signed-off-by: Lisette <lisetteslatah@gmail.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index dec258ba17..a1df90d2e0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -171,7 +171,7 @@
> [% END %]
> 
> 
>-[% IF ( WrongTransfer ) %]
>+[% IF ( WrongTransfer && !transfertodo ) %]
>     <div id="return2" class="dialog message">
>         
>         <h3>Please return item to: [% Branches.GetName( TransferWaitingAt ) | html %]</h3>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21346: 78724 | 78726 | 78902 | 78915 | 78916 | 78942 | 78943 | 79685 | 79686 | 80879 | 81100 | 81836 | 81853 | 81921 | 81924 | 82049 | 82189 | 82190 | 82191 | 82192 | 82891 | 87625 | 87626 | 87627 | 87628 | 87894 | 87895 | 87896 | 87898