Bugzilla – Attachment 82193 Details for
Bug 21804
Bad rebase reintroduced C4::Accounts::getcharges
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21804: Remove C4::Accounts::getcharges again
Bug-21804-Remove-C4Accountsgetcharges-again.patch (text/plain), 1.57 KB, created by
Tomás Cohen Arazi (tcohen)
on 2018-11-09 17:43:32 UTC
(
hide
)
Description:
Bug 21804: Remove C4::Accounts::getcharges again
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2018-11-09 17:43:32 UTC
Size:
1.57 KB
patch
obsolete
>From 199dce2fd2dd9ad0a40f85a4163762b54d470c61 Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Fri, 9 Nov 2018 16:54:34 +0000 >Subject: [PATCH] Bug 21804: Remove C4::Accounts::getcharges again > >Test plan: >1) git grep getcharges > -> should return no occurences >2) prove t/db_dependent/Accounts.t > -> should pass > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > C4/Accounts.pm | 17 ----------------- > t/db_dependent/Accounts.t | 1 - > 2 files changed, 18 deletions(-) > >diff --git a/C4/Accounts.pm b/C4/Accounts.pm >index 023856fd5b..3e59ec0fba 100644 >--- a/C4/Accounts.pm >+++ b/C4/Accounts.pm >@@ -286,23 +286,6 @@ sub manualinvoice { > return 0; > } > >-sub getcharges { >- my ( $borrowerno, $timestamp, $accountno ) = @_; >- my $dbh = C4::Context->dbh; >- my $timestamp2 = $timestamp - 1; >- my $query = ""; >- my $sth = $dbh->prepare( >- "SELECT * FROM accountlines WHERE borrowernumber=? AND accountno = ?" >- ); >- $sth->execute( $borrowerno, $accountno ); >- >- my @results; >- while ( my $data = $sth->fetchrow_hashref ) { >- push @results,$data; >- } >- return (@results); >-} >- > =head2 purge_zero_balance_fees > > purge_zero_balance_fees( $days ); >diff --git a/t/db_dependent/Accounts.t b/t/db_dependent/Accounts.t >index 82ab3820f1..4f8f94eae4 100644 >--- a/t/db_dependent/Accounts.t >+++ b/t/db_dependent/Accounts.t >@@ -44,7 +44,6 @@ can_ok( 'C4::Accounts', > getnextacctno > chargelostitem > manualinvoice >- getcharges > purge_zero_balance_fees ) > ); > >-- >2.19.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21804
:
82182
|
82193
|
82194